This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(dialog): set md-dialog-container css position attribute to fixed
#2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(dialog): set `md-dialog-container` css `position` attribute to `fixed` `position: fixed` ensures the dialog will always be center in the viewport even when scrolling
fix(backdrop): set `md-backdrop` css `position` attribute to `fixed `position: fixed` ensures the backdrop element will always cover the entire viewport
Kiougar
changed the title
md-dialog-container css position attribute to fixed
|
Will remake the pull request when I fix the commit messages. |
|
@Kiougar - whenever I see CSS changes to use 'position: fixed' I worry about sideaffects. |
|
@ThomasBurleson The second example I provided can be solved by setting |
|
@ThomasBurleson, @rschmukler Reopened in #2754. We can discuss there if there are any side effects. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the #1967. Example 1 (comment the first css line to see the problem)
Also, it fixes another issue with the sidenav toggle where the backdrop element caused the body to overflow. Example 2 (comment the second css line to see the problem)