Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(datepicker): min-date validation is incorrect in GMT+X timezones #12001

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

Splaktar
Copy link
Member

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The datepicker's min-date validation is incorrect in GMT+X timezones. See issue for details.

Issue Number:
Fixes #11963

What is the new behavior?

The validation errors in GMT+X timezones are fixed.
Some JSDoc is fixed.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

We don't have the capability to change the device's timezone between tests.

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Aug 28, 2020
@Splaktar Splaktar added i18n: localization This issue is related to internationalization P1: urgent Urgent issues that should be addressed in the next minor or patch release. severity: regression This issue is related to a regression type: bug labels Aug 28, 2020
@Splaktar Splaktar self-assigned this Aug 28, 2020
@Splaktar Splaktar added this to the 1.2.1 milestone Aug 28, 2020
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Aug 28, 2020
@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label Aug 31, 2020
@Splaktar Splaktar merged commit 7395914 into master Aug 31, 2020
@Splaktar Splaktar deleted the datepicker-fix-min-date-in-master branch August 31, 2020 18:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ i18n: localization This issue is related to internationalization P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datepicker: min-date validation bug
3 participants