This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fab-speed-dial: still triggers action when disabled #9467
Assignees
Labels
has: Pull Request
A PR has been created to address this issue
P3: important
Important issues that really should be fixed when possible.
resolution: fixed
type: bug
Milestone
Comments
|
Yup, looks like the speed dial does not currently respect the |
|
See #7473. |
Splaktar
changed the title
Splaktar
added
for: external contributor
P3: important
|
Here's an updated CodePen that shows this is still an issue in |
Splaktar
added
has: Pull Request
Splaktar
added a commit
that referenced
this issue
Dec 17, 2020
- when the trigger is clicked, verify that the trigger button isn't disabled before toggling the open state - style the disabled speed dial trigger fab button using the current theme to support both light and dark themes - fix issue where the disabled background (mostly transparent) allowed opaque `md-fab-action-item`s to fade through - disabled fab buttons now have no `box-shadow` which is consistent with Angular Material - fix basic usage demo to not have a black hover/focus background as that doesn't work at all on dark theme and was confusing in light theme - remove duplicate `$button-fab-width` variable Fixes #9467
Splaktar
added a commit
that referenced
this issue
Dec 17, 2020
- when the trigger is clicked, verify that the trigger button isn't disabled before toggling the open state - style the disabled speed dial trigger fab button using the current theme to support both light and dark themes - fix issue where the disabled background (mostly transparent) allowed opaque `md-fab-action-item`s to fade through - disabled fab buttons now have no `box-shadow` which is consistent with Angular Material - fix basic usage demo to not have a black hover/focus background as that doesn't work at all on dark theme and was confusing in light theme - add test for when the click occurs on the `md-icon` instead of the `md-button` - remove duplicate `$button-fab-width` variable Fixes #9467
3 tasks
Splaktar
added a commit
that referenced
this issue
Dec 17, 2020
- when the trigger is clicked, verify that the trigger button isn't disabled before toggling the open state - style the disabled speed dial trigger fab button using the current theme to support both light and dark themes - fix issue where the disabled background (mostly transparent) allowed opaque `md-fab-action-item`s to fade through - disabled fab buttons now have no `box-shadow` which is consistent with Angular Material - fix basic usage demo to not have a black hover/focus background as that doesn't work at all on dark theme and was confusing in light theme - add test for when the click occurs on the `md-icon` instead of the `md-button` - remove duplicate `$button-fab-width` variable Fixes #9467
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Actual Behavior:
ng-disabled="true"into md-button in md-fab-trigger. This button is disabled but able to click.Angular Versions:
Additional Information:
Demo
The text was updated successfully, but these errors were encountered: