Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

refactor(select): support for md-inline-form, more configurable SCSS #8716

Closed
wants to merge 1 commit into from
Closed

refactor(select): support for md-inline-form, more configurable SCSS #8716

wants to merge 1 commit into from

Conversation

clshortfuse
Copy link
Contributor

@clshortfuse clshortfuse commented Jun 9, 2016 •
edited
Loading

Create better flexibility for manipulating select while still
following Material Design spec

  • Add md-inline-form support
  • Add alignment math to SCSS
  • Support custom margin and padding for md-select
  • Dynamically adjust bottom margin to allow denser layouts

Fixes #8712

@clshortfuse
Copy link
Contributor Author

part of #8209

@clshortfuse clshortfuse mentioned this pull request Jun 9, 2016
Closed
@clshortfuse
Copy link
Contributor Author

clshortfuse commented Jun 9, 2016 •
edited
Loading

@ThomasBurleson I'm not sure what's going on the travis server failing to run karma-sauce

The first time it gave me a spec error related to md-tabs which wasn't modified and the second:

Sauce Connect could not establish a connection.

@clshortfuse clshortfuse mentioned this pull request Jun 9, 2016
Closed
devversion
devversion reviewed Jun 11, 2016
View reviewed changes
src/components/select/select.scss
order: 2;
margin-top: -7px; // Align with md-input-container
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is not explaining anything.

Where are the 7px from? (In source)

@clshortfuse
Copy link
Contributor Author

It's all broken now because of new changes to md-select. I'm reworking #8209 now to then rework this.

@clshortfuse clshortfuse force-pushed the specFix-select branch 2 times, most recently from 19c6872 to 61b30ec Compare June 12, 2016 18:57
@clshortfuse
Copy link
Contributor Author

clshortfuse commented Jun 12, 2016 •
edited by Splaktar
Loading

@devversion we should be good now.

Here's what master looks like: http://codepen.io/shortfuse/pen/JKGdQv

You can run gulp docs and use this: http://codepen.io/shortfuse/pen/GqoaQX for comparison

Just remember that checkbox, input container, and datepicker fixes are not part of this PR, but ideally will be fixed as I clean up the other PRs.

#8209 has more info, but I think you've seen the changes there, but this change should be non-breaking and works independently.

@clshortfuse clshortfuse force-pushed the specFix-select branch 3 times, most recently from 7bb8416 to 4e18733 Compare June 18, 2016 15:45
@clshortfuse
Copy link
Contributor Author

clshortfuse commented Jun 18, 2016 •
edited
Loading

Rebased. For comparison:

master: http://codepen.io/shortfuse/pen/JKGdQv
specFix-select http://codepen.io/shortfuse/pen/wWzzQg (this branch)
specFix: http://codepen.io/shortfuse/pen/LZRRMK (all fixes combined)

Edit: @ThomasBurleson please tag somebody to review this.

@clshortfuse clshortfuse added the needs: review This PR is waiting on review from the team label Jun 25, 2016
@clshortfuse clshortfuse changed the title fix(select) rework select to match Material Design spec feat(select) match spec; support custom margins, md-inline-form; auto horizontal margin Jun 25, 2016
@clshortfuse clshortfuse force-pushed the specFix-select branch 3 times, most recently from dbf1f0c to 0e3477e Compare July 23, 2016 17:20
@clshortfuse clshortfuse changed the title feat(select) match spec; support custom margins, md-inline-form; auto horizontal margin refactor(select) allow more flexible scss Aug 4, 2016
@clshortfuse clshortfuse added this to the 1.2.0 milestone Sep 7, 2016
@Splaktar Splaktar added pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review labels Jan 5, 2018
@Splaktar Splaktar modified the milestones: 1.1.6, 1.1.7 Jan 17, 2018
@Splaktar
Copy link
Member

This failed the presubmit process due to the following "won't be able to be merged since it breaks a lot of screendiffs (lots of changes in padding)".

So this is currently on hold until we can determine if it is possible to move forward without requiring all of the screenshot tests within Google to pass.

@Splaktar Splaktar modified the milestones: 1.1.7, - Backlog Jan 17, 2018
@Splaktar Splaktar modified the milestones: - Backlog, 1.2.0 Jan 29, 2018
@jelbourn
Copy link
Member

Clarifying: running this through tests for internal Google apps, there are over 100 different failures. Seems unlikely this will be able to be merged.

@Splaktar Splaktar removed the pr: merge ready This PR is ready for a caretaker to review label Jun 22, 2018
@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review - Breaking Change labels Mar 7, 2020
@Splaktar Splaktar removed pr: merge ready This PR is ready for a caretaker to review pr: presubmit-failures labels Apr 30, 2020
@Splaktar Splaktar added the needs: rebase This PR needs to be rebased on the latest commits from master and conflicts need to be resolved label Jul 6, 2020
@Splaktar
Copy link
Member

Splaktar commented Jul 6, 2020

@clshortfuse can you please rebase this? It's just the one select.scss file. Thanks!

@clshortfuse
Copy link
Contributor Author

clshortfuse commented Jul 6, 2020 •
edited
Loading

@Splaktar Going to need a day or two to work out how to do the testing, since IE11 support is gone from codepen.io

The object is to from this (current master) to how it used to look.

@Splaktar
Copy link
Member

Splaktar commented Jul 6, 2020 •
edited
Loading

I think that they were still supporting IE11 in Debug view (i.e. no editing).

@Splaktar
Copy link
Member

I can take this over if you'd like. I need to get this in today or tomorrow.

@clshortfuse
Copy link
Contributor Author

@Splaktar Yeah, please do. I was having a bit of trouble trying to remember all the inner workings. It's been too long to jump into this PR.

@Splaktar Splaktar changed the title refactor(select): allow more flexible scss refactor(select): support for md-inline-form, more configurable SCSS Jul 28, 2020
Splaktar pushed a commit that referenced this pull request Jul 28, 2020
@clshortfuse @Splaktar
fix(select): support for md-inline-form, more configurable SCSS
96e6949 
Create better flexibility for manipulating select while still
following Material Design spec

 - Add `md-inline-form` support
 - Add alignment math to SCSS
 - Support custom margin and padding for `md-select`
 - Dynamically adjust bottom margin to allow denser layouts

Fixes #8712. Closes #8716.
@Splaktar Splaktar mentioned this pull request Jul 28, 2020
Merged
3 tasks
Splaktar pushed a commit that referenced this pull request Jul 28, 2020
@clshortfuse @Splaktar
fix(select): support for md-inline-form, more configurable SCSS
0d4d37f 
Create better flexibility for manipulating select while still
following Material Design spec

 - Add `md-inline-form` support
 - Add alignment math to SCSS
 - Support custom margin and padding for `md-select`
 - Dynamically adjust bottom margin to allow denser layouts

Fixes #8712. Closes #8716.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Splaktar Splaktar Splaktar approved these changes

Assignees

@Splaktar Splaktar

Labels
- Breaking Change cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ CSS: High Density needs: rebase This PR needs to be rebased on the latest commits from master and conflicts need to be resolved P3: important Important issues that really should be fixed when possible. pr: lgtm This PR has been approved by the reviewer ui: CSS ux: polish
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

select: margin is outside of toolbar
8 participants
@clshortfuse @Splaktar @jelbourn @devversion @topherfangio @ThomasBurleson @googlebot @EladBezalel