Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

select: margin is outside of toolbar #8712

Closed
epelc opened this issue Jun 9, 2016 · 1 comment · Fixed by #11983
Closed

select: margin is outside of toolbar #8712

epelc opened this issue Jun 9, 2016 · 1 comment · Fixed by #11983
Assignees
@Splaktar
Labels
has: Pull Request A PR has been created to address this issue P3: important Important issues that really should be fixed when possible. resolution: fixed type: bug ui: CSS
Milestone
1.2.0

Comments

@epelc
Copy link
Contributor

epelc commented Jun 9, 2016

Actual behavior:

CodePen or Steps to reproduce the issue: *

Angular Versions: *

  • Angular Version: I also tested locally 1.5.6
  • Angular Material Version: 1.0.9

Additional Information:

  • Browser Type: * chrome
  • Browser Version: * 51.0.2704.84 (64-bit)
  • OS: * os x 10.11.5
  • Stack Traces:

Shortcut to create a new CodePen Demo.
Note: * indicates required information. Without this information, your issue may be auto-closed.

Do not modify the titles or questions. Simply add your responses to the ends of the questions.
Add more lines if needed.
@clshortfuse
Copy link
Contributor

#8716 has new layout for md-select which does away with some of the previous margins. I believe it would fix the problem.

@ThomasBurleson ThomasBurleson added this to the 1.1.1 milestone Jul 25, 2016
@clshortfuse clshortfuse self-assigned this Jul 28, 2016
@clshortfuse clshortfuse added the has: Pull Request A PR has been created to address this issue label Jul 28, 2016
clshortfuse added a commit to clshortfuse/material that referenced this issue Aug 4, 2016
@clshortfuse
refactor(select) allow more flexible scss
696cf9f 
Create better flexibility for manipulating checkbox while still
following Material Design spec

 - Add md-inline-form support
 - Add alignment math to SCSS
 - Support custom margin and padding for md-select
 - Dynamically adjust bottom margin to allow denser layouts

Fixes angular#8712
@clshortfuse clshortfuse mentioned this issue Aug 4, 2016
Closed
clshortfuse added a commit to clshortfuse/material that referenced this issue Aug 4, 2016
@clshortfuse
refactor(select) allow more flexible scss
ab008b9 
Create better flexibility for manipulating select while still
following Material Design spec

 - Add md-inline-form support
 - Add alignment math to SCSS
 - Support custom margin and padding for md-select
 - Dynamically adjust bottom margin to allow denser layouts

Fixes angular#8712
clshortfuse added a commit to clshortfuse/material that referenced this issue Aug 15, 2016
@clshortfuse
refactor(select) allow more flexible scss
71a94cc 
Create better flexibility for manipulating select while still
following Material Design spec

 - Add md-inline-form support
 - Add alignment math to SCSS
 - Support custom margin and padding for md-select
 - Dynamically adjust bottom margin to allow denser layouts

Fixes angular#8712
clshortfuse added a commit to clshortfuse/material that referenced this issue Nov 17, 2016
@clshortfuse
refactor(select) allow more flexible scss
a6ea061 
Create better flexibility for manipulating select while still
following Material Design spec

 - Add md-inline-form support
 - Add alignment math to SCSS
 - Support custom margin and padding for md-select
 - Dynamically adjust bottom margin to allow denser layouts

Fixes angular#8712
clshortfuse added a commit to clshortfuse/material that referenced this issue Nov 17, 2016
@clshortfuse
fix(select) correct style to spec and improve horizontal alignment
724052e 
Create better flexibility for manipulating select while still
following Material Design spec

 - Add md-inline-form support
 - Add alignment math to SCSS
 - Support custom margin and padding for md-select
 - Dynamically adjust bottom margin to allow denser layouts

Fixes angular#8712
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.1, 1.1.3 Nov 29, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.3, 1.2.0 Jan 1, 2017
@Splaktar Splaktar modified the milestones: Future, 1.2.0 Jan 29, 2018
@Splaktar Splaktar changed the title mdSelect: Margin is outside of toolbar select: margin is outside of toolbar Feb 23, 2019
@Splaktar Splaktar added P3: important Important issues that really should be fixed when possible. type: bug labels Jul 6, 2020
@Splaktar Splaktar self-assigned this Jul 6, 2020
Splaktar pushed a commit that referenced this issue Jul 28, 2020
@clshortfuse @Splaktar
fix(select): support for md-inline-form, more configurable SCSS
96e6949 
Create better flexibility for manipulating select while still
following Material Design spec

 - Add `md-inline-form` support
 - Add alignment math to SCSS
 - Support custom margin and padding for `md-select`
 - Dynamically adjust bottom margin to allow denser layouts

Fixes #8712. Closes #8716.
@Splaktar Splaktar mentioned this issue Jul 28, 2020
Merged
3 tasks
Splaktar pushed a commit that referenced this issue Jul 28, 2020
@clshortfuse @Splaktar
fix(select): support for md-inline-form, more configurable SCSS
0d4d37f 
Create better flexibility for manipulating select while still
following Material Design spec

 - Add `md-inline-form` support
 - Add alignment math to SCSS
 - Support custom margin and padding for `md-select`
 - Dynamically adjust bottom margin to allow denser layouts

Fixes #8712. Closes #8716.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Splaktar Splaktar

Labels
has: Pull Request A PR has been created to address this issue P3: important Important issues that really should be fixed when possible. resolution: fixed type: bug ui: CSS
Projects
None yet
Milestone
1.2.0
4 participants
@ThomasBurleson @Splaktar @epelc @clshortfuse