Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

dialog: dialog content id is assigned to dialogContent_undefined #7469

Closed
devversion opened this issue Mar 8, 2016 · 0 comments
Closed

dialog: dialog content id is assigned to dialogContent_undefined #7469

devversion opened this issue Mar 8, 2016 · 0 comments
Assignees
@devversion
Labels
pr: merge ready This PR is ready for a caretaker to review

Comments

@devversion
Copy link
Member

There's currently a wrong snippet for the dialogContent ids.
See https://github.com/angular/material/blob/master/src/components/dialog/dialog.js#L897

image
@devversion devversion added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Mar 8, 2016
@devversion devversion self-assigned this Mar 8, 2016
devversion added a commit to devversion/material that referenced this issue Mar 9, 2016
@devversion
fix(dialog): prefix dialog content probably
6616586 
At the moment, the dialog always retrieved an id of `dialogContent_undefined`

Fixes angular#7469
@devversion devversion mentioned this issue Mar 9, 2016
Closed
@devversion devversion added pr: merge ready This PR is ready for a caretaker to review and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Mar 9, 2016
ThomasBurleson pushed a commit that referenced this issue Apr 1, 2016
@devversion @ThomasBurleson
fix(dialog): prefix dialog content probably
3a41828 
At the moment, the dialog always retrieved an id of `dialogContent_undefined`

Fixes #7469. Closes #7480

# Conflicts:
#	src/components/dialog/dialog.spec.js
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@devversion