Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-whiteframe needs to be an attribute directive #6772

Closed
ThomasBurleson opened this issue Jan 20, 2016 · 0 comments
Closed

md-whiteframe needs to be an attribute directive #6772

ThomasBurleson opened this issue Jan 20, 2016 · 0 comments
Labels
P2: required Issues that must be fixed.

Comments

@ThomasBurleson
Copy link
Contributor

Currently .md-whiteframe-<xxx>dp used only as a class specifier.

 <md-whiteframe class="md-whiteframe-1dp"> 
    using .md-whiteframe-1dp
</md-whiteframe>

  <md-whiteframe class="md-whiteframe-2dp"> 
    using .md-whiteframe-2dp 
</md-whiteframe>

This is very confusing since all the other components and tags are Element or Attribute directives.

Much like the Layout directives, we should support the following directive notation:

<div  md-whiteframe="3"> ... </div> 

which will render as

<div  class="md-whiteframe-3dp"> ... </div> 

This is more congruent with the other components and directives in Angular Material.

Use of the md-whiteframe directive without a value should default to 4 (aka 4dp)

@ThomasBurleson ThomasBurleson added the P2: required Issues that must be fixed. label Jan 20, 2016
@ThomasBurleson ThomasBurleson added this to the Backlog milestone Jan 20, 2016
@ThomasBurleson ThomasBurleson changed the title mdWhiteframe needs to be offered as a directive md-whiteframe needs to be offered as a attribute directive Jan 20, 2016
@ThomasBurleson ThomasBurleson changed the title md-whiteframe needs to be offered as a attribute directive md-whiteframe needs to be an attribute directive Jan 20, 2016
devversion added a commit to devversion/material that referenced this issue Jan 24, 2016
devversion added a commit to devversion/material that referenced this issue Jan 24, 2016
devversion added a commit to devversion/material that referenced this issue Jan 24, 2016
devversion added a commit to devversion/material that referenced this issue Jan 25, 2016
devversion added a commit to devversion/material that referenced this issue Jan 26, 2016
ErinCoughlan pushed a commit to ErinCoughlan/material that referenced this issue Feb 9, 2016
…classes

`md-whiteframe` can now be used as a class or a directive attribute.

Fixes angular#6772, closes angular#6831.
@Splaktar Splaktar removed this from the - Backlog milestone Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2: required Issues that must be fixed.
Projects
None yet
Development

No branches or pull requests

3 participants