This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
md-dialog: Timing change on backdrop removal in newer commits to master #3826
Assignees
Milestone
Comments
ThomasBurleson
added a commit
that referenced
this issue
Jul 21, 2015
improve backdrop animations and css to account for scroll and parenting: backdrop - css uses transition and ng-enter/ng-leav - css transitions opacity instead of background-color - css no longer uses key frames - postLink uses $animate.pin if available - postLink logs a warning if the backdrop parent has a style 'position:static' util - disableElementScroll uses specified element or body; used by dialog to disable dialog parent scrolling when parent is explicitly specified dialog - css for 'md-dialog-container' is now 'position:absolute'; 'fixed' is deprecated - hide backdrop now runs in parallel with hide dialog - basic demo #1 now uses element '#popupContainer' as parent; instead of document.body - basic demo #1 has #popupContainer 'position:relative' styling Fixes #3826, #3828, #1967, #1106
ThomasBurleson
added a commit
that referenced
this issue
Jul 21, 2015
improve backdrop animations and css to account for scroll and parenting: - backdrop - css uses transition and ng-enter/ng-leav - css transitions opacity instead of background-color - css no longer uses key frames - postLink uses $animate.pin if available - postLink logs a warning if the backdrop parent has a style 'position:static' - util - disableElementScroll uses specified element or body; used by dialog to disable dialog parent scrolling when parent is explicitly specified - refactor(util): centralize use of backdrop $compile - dialog - css for 'md-dialog-container' is now 'position:absolute'; 'fixed' is deprecated - hide backdrop now runs in parallel with hide dialog - basic demo #1 now uses element '#popupContainer' as parent; instead of document.body - basic demo #1 has #popupContainer 'position:relative' styling Fixes #3826, #3828, #1967, #1106
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Is it just me, or is there a definite change in the newer commits that changes the way the backdrop is removed when an md-dialog is dismissed? In previous versions 0.10.0 for certain, perhaps even 0.10.1-rc1, dismissing a dialog would transition the backdrop simultaneously with the removal of the dialog itself. Now, however, as of the recent commits, this behavior has been replaced with a two stage process where the dialog first shrinks away (stage 1), and then the backdrop fades out (stage 2).
This change has been somewhat jarring, and although I can not find a specific example or page in the Material Design guidebook related to UI interactions for the display and removal of dialogs, by grabbing my Android phone it seems like this is not the behavior cooked into material design in the Google apps I tested. It seems like the backdrop fade and dialog dismissal are simultaneous, and not delayed. I'd guess the backdrop is now tied to a timeout or promise in the code which explains why it is waiting to happen after the dialog has disappeared.
Will this be corrected or is this the planned UI behavior as of this time for the future?
The text was updated successfully, but these errors were encountered: