Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

secondary and primary placeholders switched in md-chips #2770

Closed
typotter opened this issue May 7, 2015 · 2 comments
Closed

secondary and primary placeholders switched in md-chips #2770

typotter opened this issue May 7, 2015 · 2 comments
Assignees
@typotter
Milestone
Deprecated

Comments

@typotter
Copy link
Contributor

typotter commented May 7, 2015

In the Chips Basic Usage Demo, under 'Use Placeholders and override hint texts'. The placeholder text should be +tag when the collection is non empty, and the longer, "Enter a tag" when the collection is empty.
@typotter typotter self-assigned this May 7, 2015
@ThomasBurleson ThomasBurleson modified the milestone: 0.10.0 May 13, 2015
@robertmesserle robertmesserle modified the milestones: 0.10.1, 0.10.0 Jun 16, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 0.10.1, 0.11.0, REVISIT Jul 31, 2015
@ThomasBurleson ThomasBurleson added the needs: review This PR is waiting on review from the team label Jul 31, 2015
@typotter typotter modified the milestones: 1.0-beta1, REVISIT Aug 10, 2015
@typotter typotter removed the needs: review This PR is waiting on review from the team label Aug 10, 2015
@naomiblack naomiblack modified the milestones: 1.0-beta1, 0.12.0 Aug 14, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc1, 1.0-rc2, 1.0-rc3 Oct 27, 2015
@ThomasBurleson ThomasBurleson removed this from the 1.0-rc3 milestone Nov 7, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc5, 1.0-rc8 Nov 25, 2015
@ericgundrum
Copy link
Contributor

This is caused by a logic error on line 186 of src/components/chips/js/chipsController.js
return useSecondary ? this.placeholder : this.secondaryPlaceholder;
should be
return useSecondary ? this.secondaryPlaceholder : this.placeholder;

Note that this error appears in production code, not just in the demo. The error is present on branch master as well as tag 1.0.0-rc7.

@ericgundrum ericgundrum mentioned this issue Dec 11, 2015
Closed
@ericgundrum
Copy link
Contributor

The pull request @dbwhddn10 associated with #3804 will fix this issue.

@ericgundrum ericgundrum mentioned this issue Jan 1, 2016
Closed
ericgundrum added a commit to ericgundrum/material that referenced this issue Jan 4, 2016
@ericgundrum
test (mdChips: placeholder): add missing tests
7f38bc1 
Add tests for the placeholder feature of `chipsController`(<mdChips>).
Previously there were no tests.

These tests demonstrate the failures reported as github issues angular#2770 and angular#4476.
ericgundrum added a commit to ericgundrum/material that referenced this issue Jan 4, 2016
@ericgundrum
fix(md-chips placeholder): correct placeholder/secondary logic
6064a1d 
The logic test deciding when to show the secondary placeholder was backwards, causing the secondary placeholder to be shown when no chips were present.

Fixes github issues angular#2770 and angular#4476.
@ericgundrum ericgundrum mentioned this issue Jan 4, 2016
Closed
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc8, 1.1.0, Backlog Jan 5, 2016
ThomasBurleson pushed a commit that referenced this issue Feb 4, 2016
@ericgundrum @ThomasBurleson
test (mdChips: placeholder): add missing tests
d2953a9 
Add tests for the placeholder feature of `chipsController`(<mdChips>).
Previously there were no tests.

These tests demonstrate the failures reported as github issues #2770 and #4476.
ThomasBurleson pushed a commit that referenced this issue Feb 4, 2016
@ericgundrum @ThomasBurleson
fix(md-chips placeholder): correct placeholder/secondary logic
dfd4ba2 
The logic test deciding when to show the secondary placeholder was backwards, causing the secondary placeholder to be shown when no chips were present.

Fixes github issues #2770 and #4476.

Closes #6535
ThomasBurleson pushed a commit that referenced this issue Feb 4, 2016
@ericgundrum @ThomasBurleson
test (mdChips: placeholder): add missing tests
44626d7 
Add tests for the placeholder feature of `chipsController`(<mdChips>).
Previously there were no tests.

These tests demonstrate the failures reported as github issues #2770 and #4476.
ThomasBurleson pushed a commit that referenced this issue Feb 4, 2016
@ericgundrum @ThomasBurleson
fix(md-chips placeholder): correct placeholder/secondary logic
367d0cc 
The logic test deciding when to show the secondary placeholder was backwards, causing the secondary placeholder to be shown when no chips were present.

Fixes github issues #2770 and #4476.

  Closes #6535
ErinCoughlan pushed a commit to ErinCoughlan/material that referenced this issue Feb 9, 2016
@ericgundrum @ErinCoughlan
test (mdChips: placeholder): add missing tests
18f47d3 
Add tests for the placeholder feature of `chipsController`(<mdChips>).
Previously there were no tests.

These tests demonstrate the failures reported as github issues angular#2770 and angular#4476.
ErinCoughlan pushed a commit to ErinCoughlan/material that referenced this issue Feb 9, 2016
@ericgundrum @ErinCoughlan
fix(md-chips placeholder): correct placeholder/secondary logic
58bf6de 
The logic test deciding when to show the secondary placeholder was backwards, causing the secondary placeholder to be shown when no chips were present.

Fixes github issues angular#2770 and angular#4476.

Closes angular#6535
@ThomasBurleson ThomasBurleson modified the milestones: Backlog, Deprecated Apr 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@typotter typotter

Labels
None yet
Projects
None yet
Milestone
Deprecated
Development

No branches or pull requests
5 participants
@ThomasBurleson @robertmesserle @ericgundrum @naomiblack @typotter