This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
md-chips checks for duplicates before md-on-append is called #2748
Comments
|
+1 |
topherfangio
added a commit
that referenced
this issue
Aug 11, 2015
The duplicate check was firing before the user's onAppend method had a chance to run, so the check would always compare a string against an object and fail. fixes #2748
topherfangio
added
the
pr: merge ready
topherfangio
added a commit
that referenced
this issue
Aug 13, 2015
The duplicate check was firing before the user's onAppend method had a chance to run, so the check would always compare a string against an object and fail. fixes #2748
kennethcachia
pushed a commit
to kennethcachia/material
that referenced
this issue
Sep 23, 2015
The duplicate check was firing before the user's onAppend method had a chance to run, so the check would always compare a string against an object and fail. fixes angular#2748. closes angular#4113.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The appendChip function in chipsController.js does some duplicate-checking to prevent adding the same chip multiple times. Unfortunately, it checks for matches before md-on-append is called. If md-on-append converts a string input into an object, for instance, the duplicate checking will always fail.
Presumably it should either check for duplicates after md-on-append has been called, or keep a separate collection of unmodified chips to check against.
The text was updated successfully, but these errors were encountered: