Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Add Divider components #194

Closed
ThomasBurleson opened this issue Aug 26, 2014 · 5 comments
Closed

Add Divider components #194

ThomasBurleson opened this issue Aug 26, 2014 · 5 comments
Assignees
Milestone

Comments

@ThomasBurleson
Copy link
Contributor

Material Design Specifications

Full Bleed Dividers:
image

Inset Dividers:
image

Dividers and SubHeaders
image

@ThomasBurleson ThomasBurleson added this to the 0.0.4 milestone Aug 26, 2014
@ThomasBurleson ThomasBurleson changed the title Implement Divider components Add Divider components Aug 26, 2014
@ThomasBurleson ThomasBurleson modified the milestones: 0.0.3, 0.0.4 Aug 30, 2014
@ThomasBurleson
Copy link
Contributor Author

Essentially appears to be a vertical spacer with a line effect and [optional] text.

@EisenbergEffect
Copy link
Contributor

It seems very simple, unless I'm missing something. I think it's a good starting place to make sure I've got your project workflow and conventions down and to start getting more aquatinted with the spec and the existing codebase.

@ThomasBurleson
Copy link
Contributor Author

I'll be curious how you implement the component for both full and inset bleeds. Perhaps

<material-divider bleed="full"> SubHeader Text </material-divider>

@EisenbergEffect
Copy link
Contributor

That's pretty close to what I was thinking. If that sound like a good idea
to you, I'll go that way.

@ThomasBurleson
Copy link
Contributor Author

Agreed that Divider is a great starting component.
@EisenbergEffect you have that unique level of experience and skills that urge me to say: "Pick any non-in-progress component you like, I am sure the implementation will be great."

EisenbergEffect added a commit that referenced this issue Sep 9, 2014
This commit adds an implementation of the "divider" component which groups and separates content within lists and page layouts using strong visual and spatial distinctions. Demos, docs and a small test suite accompany the implementation.

Closes #194
EisenbergEffect added a commit that referenced this issue Sep 11, 2014
This commit adds an implementation of the "divider" component which groups and separates content within lists and page layouts using strong visual and spatial distinctions. Demos and docs accompany the implementation.

Closes #194
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants