Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-button: href ripple color #1486

Closed
epelc opened this issue Feb 12, 2015 · 4 comments
Closed

md-button: href ripple color #1486

epelc opened this issue Feb 12, 2015 · 4 comments
Assignees
Milestone

Comments

@epelc
Copy link
Contributor

epelc commented Feb 12, 2015

If you have a button with an href the ripple color is red. Shouldn't it default to light grey if you don't add any classes to the button?

<md-button href="http://www.google.com/" target="_blank">Google</md-button>
@ThomasBurleson ThomasBurleson modified the milestone: 0.8.0 Feb 17, 2015
@marcysutton
Copy link
Contributor

I'm actually seeing the default blue/purple colors for links that get added in place of <md-button>. @epelc, are you using a theme?

@marcysutton
Copy link
Contributor

Ahh, I am noticing it's the ripple color, not the foreground color. It seems related to the default color issue I mentioned above.

@epelc
Copy link
Contributor Author

epelc commented Feb 17, 2015

I tried it in my app which uses a modified green theme and on the docs.

@marcysutton
Copy link
Contributor

I don't see red ripples anywhere in the docs, although I did see them on Codepen (which has a default stylesheet). The "Go to Google" link button in Demos > Button inherits a blue text color from our docs.css, which highlights that a default color is missing from the component itself. I am updating md-button to use color: currentColor in the absence of a theme class. That way it will update based on the body color.

Something to keep in mind is we're adding basic typography support in 0.9.0. So if we want to make changes to this behavior, we can revisit it then. #1128

marcysutton pushed a commit that referenced this issue Feb 17, 2015
@ajoslin ajoslin added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Feb 19, 2015
marcysutton pushed a commit that referenced this issue Feb 19, 2015
@ajoslin ajoslin removed the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Feb 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants