This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(tabs): fix exceptions on IE11 when tabs are in a dialog
`elements.dummies` is not always valid on IE11. It often throws `Invalid calling object`. The fix is to call `getElements()` to do a fresh look up of the selectors each time. Only doing the `getElements()` call when the exception is throw was tried. It resulted in improperly loading/sizing of tabs on small screen sizes. Fixes #3953.
- Loading branch information
Showing
4 changed files
with
73 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
<md-dialog aria-label="Mango (Fruit)"> | ||
<form> | ||
<md-toolbar> | ||
<div class="md-toolbar-tools"> | ||
<h2>Mango (Fruit)</h2> | ||
<span flex></span> | ||
<md-button class="md-icon-button" ng-click="cancel()"> | ||
<md-icon md-svg-src="img/icons/ic_close_24px.svg" aria-label="Close dialog"></md-icon> | ||
</md-button> | ||
</div> | ||
</md-toolbar> | ||
<md-dialog-content style="max-width:800px;max-height:810px; "> | ||
<md-tabs md-dynamic-height md-border-bottom> | ||
<md-tab label="one"> | ||
<md-content class="md-padding"> | ||
<h1 class="md-display-2">Tab One</h1> | ||
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nulla venenatis ante augue. Phasellus volutpat neque ac dui mattis vulputate. Etiam consequat aliquam cursus. In sodales pretium ultrices. Maecenas lectus est, sollicitudin consectetur felis nec, feugiat ultricies mi.</p> | ||
</md-content> | ||
</md-tab> | ||
<md-tab label="two"> | ||
<md-content class="md-padding"> | ||
<h1 class="md-display-2">Tab Two</h1> | ||
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nulla venenatis ante augue. Phasellus volutpat neque ac dui mattis vulputate. Etiam consequat aliquam cursus. In sodales pretium ultrices. Maecenas lectus est, sollicitudin consectetur felis nec, feugiat ultricies mi. Aliquam erat volutpat. Nam placerat, tortor in ultrices porttitor, orci enim rutrum enim, vel tempor sapien arcu a tellus. Vivamus convallis sodales ante varius gravida. Curabitur a purus vel augue ultrices ultricies id a nisl. Nullam malesuada consequat diam, a facilisis tortor volutpat et. Sed urna dolor, aliquet vitae posuere vulputate, euismod ac lorem. Sed felis risus, pulvinar at interdum quis, vehicula sed odio. Phasellus in enim venenatis, iaculis tortor eu, bibendum ante. Donec ac tellus dictum neque volutpat blandit. Praesent efficitur faucibus risus, ac auctor purus porttitor vitae. Phasellus ornare dui nec orci posuere, nec luctus mauris semper.</p> | ||
<p>Morbi viverra, ante vel aliquet tincidunt, leo dolor pharetra quam, at semper massa orci nec magna. Donec posuere nec sapien sed laoreet. Etiam cursus nunc in condimentum facilisis. Etiam in tempor tortor. Vivamus faucibus egestas enim, at convallis diam pulvinar vel. Cras ac orci eget nisi maximus cursus. Nunc urna libero, viverra sit amet nisl at, hendrerit tempor turpis. Maecenas facilisis convallis mi vel tempor. Nullam vitae nunc leo. Cras sed nisl consectetur, rhoncus sapien sit amet, tempus sapien.</p> | ||
<p>Integer turpis erat, porttitor vitae mi faucibus, laoreet interdum tellus. Curabitur posuere molestie dictum. Morbi eget congue risus, quis rhoncus quam. Suspendisse vitae hendrerit erat, at posuere mi. Cras eu fermentum nunc. Sed id ante eu orci commodo volutpat non ac est. Praesent ligula diam, congue eu enim scelerisque, finibus commodo lectus.</p> | ||
</md-content> | ||
</md-tab> | ||
<md-tab label="three"> | ||
<md-content class="md-padding"> | ||
<h1 class="md-display-2">Tab Three</h1> | ||
<p>Integer turpis erat, porttitor vitae mi faucibus, laoreet interdum tellus. Curabitur posuere molestie dictum. Morbi eget congue risus, quis rhoncus quam. Suspendisse vitae hendrerit erat, at posuere mi. Cras eu fermentum nunc. Sed id ante eu orci commodo volutpat non ac est. Praesent ligula diam, congue eu enim scelerisque, finibus commodo lectus.</p> | ||
</md-content> | ||
</md-tab> | ||
</md-tabs> | ||
</md-dialog-content> | ||
|
||
<div class="md-actions" layout="row"> | ||
<md-button href="http://en.wikipedia.org/wiki/Mango" target="_blank" md-autofocus> | ||
More on Wikipedia | ||
</md-button> | ||
<span flex></span> | ||
<md-button ng-click="answer('not useful')" > | ||
Not Useful | ||
</md-button> | ||
<md-button ng-click="answer('useful')" style="margin-right:20px;" > | ||
Useful | ||
</md-button> | ||
</div> | ||
</form> | ||
</md-dialog> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters