Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update to Angular and CLI v12 next.7 and Components v12 next.5 #939

Merged
merged 1 commit into from
Apr 8, 2021
Merged

build: update to Angular and CLI v12 next.7 and Components v12 next.5 #939

merged 1 commit into from
Apr 8, 2021

Conversation

Splaktar
Copy link
Member

@Splaktar Splaktar commented Apr 7, 2021 •
edited
Loading

  • fix typing change in ActivatedRoute.fragment
  • fix breaking change to no longer allow the styles bundleName to include a path in the ng build config

@Splaktar Splaktar added P2: required dependencies Pull requests that update a dependency file labels Apr 7, 2021
@google-cla google-cla bot added the cla: yes label Apr 7, 2021
@Splaktar Splaktar mentioned this pull request Apr 7, 2021
Closed
15 tasks
@Splaktar
Copy link
Member Author

Splaktar commented Apr 7, 2021 •
edited
Loading

It looks like these test typing errors with components-examples may be related to needing PR angular/components#22390 to land with Angular 12.0.0-next.7 support prior to our docs site moving to that version.

@Splaktar Splaktar requested a review from crisbeto April 7, 2021 04:12
wagnermaciel
wagnermaciel approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wagnermaciel
Copy link
Contributor

@Splaktar You have a CircleCI failure here but otherwise LGTM

@Splaktar Splaktar removed the request for review from andrewseguin April 7, 2021 15:25
@Splaktar
Copy link
Member Author

Splaktar commented Apr 7, 2021

I'll update now that PR angular/components#22390 is merged and CI should be good to go.

@Splaktar Splaktar requested a review from annieyw April 8, 2021 00:23
@Splaktar
build: update to Angular and CLI v12 next.7 and Components v12 next.5
fb4a322 
- fix typing change in `ActivatedRoute.fragment`
- fix [breaking change](angular/angular-cli#20361)
  to no longer allow the styles `bundleName` to include a path in the ng build config
@Splaktar Splaktar merged commit 8583f02 into angular:master Apr 8, 2021
@Splaktar Splaktar deleted the update-dependencies branch April 8, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

@annieyw annieyw Awaiting requested review from annieyw

Assignees
No one assigned
Labels
cla: yes dependencies Pull requests that update a dependency file P2: required pr: lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Splaktar @wagnermaciel