Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

fix(show-hide): display set to "initial" value if parent has no display set #1168

Closed
wants to merge 1 commit into from
Closed

fix(show-hide): display set to "initial" value if parent has no display set #1168

wants to merge 1 commit into from

Conversation

vmasek
Copy link

@vmasek vmasek commented Jan 2, 2020

When SSR creates media screen styles it sets the default display to parent.display, but if the parent has its display property unset, it results in an empty display which breaks the correct functionality as the next closest match is made.

Fixed by setting display to initial as default instead of an empty value.

fixes #1163

@vmasek
Copy link
Author

vmasek commented Jan 2, 2020

As I see the tests fail, I'm not sure if this actually breaks something or how to altern the tests to match this behaviour. Please leave feedback on what do you think and I'll try to fix it.

@gurkan0791
Copy link

It's my understanding that I should add "fxLayout" to all "mat-header-cell" and "mat-cell" tags?Otherwise it will be corrupted due to "display: initial".
For Example, Stackblitz

@CaerusKaru
Copy link
Member

@gurkan0791 I’m a little confused by your comment; can you open an issue with your StackBlitz along with what you think the expected behavior should be?

@CaerusKaru
Copy link
Member

Tracking in #1250

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fxHide/fxShow incosistency with SSR and client rendered app
4 participants