Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

Orientation media queries defined in orientation-break-points.ts seem to be using incorrect pluralisation #763

Closed
Mufasa opened this issue Jun 6, 2018 · 3 comments · Fixed by #765
Assignees
Labels
bug has pr A PR has been created to address this issue P1 Urgent issue that should be resolved before the next re-lease

Comments

@Mufasa
Copy link

Mufasa commented Jun 6, 2018

Bug, feature request, or proposal:

I think there is a bug in the file src/lib/core/breakpoints/data/orientation-break-points.ts

What is the expected behavior?

The media queries in there use (orientations: ...) rather than (orientation: ...) - note the pluralisation in the word orientations. I believe the singular form is the correct version, see here: https://developer.mozilla.org/en-US/docs/Web/CSS/@media/orientation

What is the current behavior?

What are the steps to reproduce?

What is the use-case or motivation for changing an existing behavior?

To improve the product

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Is there anything else we should know?

@CaerusKaru CaerusKaru added bug has pr A PR has been created to address this issue P1 Urgent issue that should be resolved before the next re-lease labels Jun 7, 2018
@CaerusKaru CaerusKaru added this to the v6.0.0-beta.17 milestone Jun 7, 2018
@CaerusKaru CaerusKaru self-assigned this Jun 7, 2018
@CaerusKaru
Copy link
Member

Thanks for finding this, it should be patched by #765

@ThomasBurleson
Copy link
Contributor

@Mufasa - great catch. Thank yo.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug has pr A PR has been created to address this issue P1 Urgent issue that should be resolved before the next re-lease
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants