Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

Incorrect max-width: 0px; when using fxFlex="1 1 0px" #534

Closed
AbakumovAlexandr opened this issue Dec 14, 2017 · 2 comments · Fixed by #629
Closed

Incorrect max-width: 0px; when using fxFlex="1 1 0px" #534

AbakumovAlexandr opened this issue Dec 14, 2017 · 2 comments · Fixed by #629
Assignees
@ThomasBurleson @CaerusKaru
Labels
has pr A PR has been created to address this issue P1 Urgent issue that should be resolved before the next re-lease
Milestone
v5.0.0-beta.14

Comments

@AbakumovAlexandr
Copy link

Bug, feature request, or proposal:

Bug.

What is the expected behavior?

Effect of generated CSS properties in case of fxFlex="1 1 0px" should match the one of flex: 1 1 0px;.

What is the current behavior?

When you use fxFlex="1 1 0px", max-width: 0px; is getting added to an element which breaks displaying of the element in some cases.

What are the steps to reproduce?

This is side-by-side demonstration of the issue with a simplified layout from my project:
StackBlitz

What is the use-case or motivation for changing an existing behavior?

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Tested in IE 11, Edge, FF 57, Chrome 63.0.3239.84.
Angular 5.1.1, Material 5.0.1, Win 10, TS 2.4.2.

Is there anything else we should know?
@AbakumovAlexandr AbakumovAlexandr changed the title Incorrect max-width: 0px; Incorrect max-width: 0px; when using fxFlex="1 1 0px" Dec 14, 2017
@ThomasBurleson
Copy link
Contributor

ThomasBurleson commented Dec 15, 2017 •
edited
Loading

Related to #280, #277, #538, #528

@ThomasBurleson ThomasBurleson added the P1 Urgent issue that should be resolved before the next re-lease label Dec 15, 2017
@ThomasBurleson ThomasBurleson added this to the v2.0.0-beta.13 milestone Dec 15, 2017
@ThomasBurleson ThomasBurleson self-assigned this Dec 15, 2017
CaerusKaru added a commit to CaerusKaru/flex-layout that referenced this issue Feb 25, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
a3204b2 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set

Fixes angular#277
Fixes angular#280
Fixes angular#528
Fixes angular#534
@CaerusKaru CaerusKaru mentioned this issue Feb 25, 2018
Closed
@CaerusKaru CaerusKaru added has pr A PR has been created to address this issue and removed in-progress labels Feb 25, 2018
CaerusKaru added a commit that referenced this issue Feb 25, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
e23e2a0 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
@CaerusKaru CaerusKaru mentioned this issue Feb 25, 2018
Merged
CaerusKaru added a commit to CaerusKaru/flex-layout that referenced this issue Feb 25, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
9a1d709 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes angular#277
Fixes angular#280
Fixes angular#323
Fixes angular#528
Fixes angular#534
CaerusKaru added a commit that referenced this issue Feb 25, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
4ae757f 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
CaerusKaru added a commit that referenced this issue Feb 25, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
1a3029f 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
CaerusKaru added a commit that referenced this issue Mar 4, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
421a18a 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
CaerusKaru added a commit that referenced this issue Mar 9, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
45b29f2 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
CaerusKaru added a commit that referenced this issue Mar 9, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
a0ac344 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
CaerusKaru added a commit that referenced this issue Mar 9, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
7ab5d34 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
CaerusKaru added a commit that referenced this issue Mar 9, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
6f8c7ab 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
CaerusKaru added a commit that referenced this issue Mar 9, 2018
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings (#629)
1e96cea 
* fix for when flex-basis is unitless and 0
* fix for when no width/height is applied and flex-basis should be
  set
* fix for IE flex-basis with calc values
* fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ThomasBurleson ThomasBurleson

@CaerusKaru CaerusKaru

Labels
has pr A PR has been created to address this issue P1 Urgent issue that should be resolved before the next re-lease
Projects
None yet
Milestone
v5.0.0-beta.14
3 participants
@ThomasBurleson @CaerusKaru @AbakumovAlexandr