Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

Flex-layout needs to upgrade to Renderer2 #326

Closed
matsko opened this issue Jun 23, 2017 · 1 comment · Fixed by #372
Closed

Flex-layout needs to upgrade to Renderer2 #326

matsko opened this issue Jun 23, 2017 · 1 comment · Fixed by #372
Labels
has pr A PR has been created to address this issue P1 Urgent issue that should be resolved before the next re-lease
Milestone
v2.0.0-beta.9

Comments

@matsko
Copy link
Contributor

matsko commented Jun 23, 2017

There have been some recent refactorings in angular/angular that change NgClass and other directives to use Renderer2 instead of Renderer. While this change is transparent to the public API of Angular, it is still a change that causes issues to code that extends the base directives that Angular has to offer.

With flex-layout, the NgClass, NgStyle and other directives are extended. This is an anti-pattern and isn't encouraged by Angular itself. Therefore there are two things that need to be changed in flex-layouts so that it's compatible with future versions of Angular.

  1. Use Renderer2 instead of Renderer
  2. Do not extend the Angular base directives, but instead inject them into the constructor.

Once this code changes have been made then flex-layouts can work with both Angular4 and Angular5.
@ThomasBurleson ThomasBurleson added the P1 Urgent issue that should be resolved before the next re-lease label Jun 23, 2017
@ThomasBurleson ThomasBurleson added this to the v2.0.0-beta.10 milestone Jun 23, 2017
@ThomasBurleson ThomasBurleson modified the milestones: v2.0.0-beta.9, v2.0.0-beta.10 Aug 8, 2017
ThomasBurleson added a commit that referenced this issue Aug 9, 2017
@ThomasBurleson
fix(api): use Renderer2 instead of Renderer
59bb313 
* Use Renderer2 instead of Renderer
* Do not extend the Angular base directives, but instead inject them into the constructor.
* improve support for future releases of Angular 5

Fixes #326.
@ThomasBurleson ThomasBurleson mentioned this issue Aug 9, 2017
Merged
ThomasBurleson added a commit that referenced this issue Aug 9, 2017
@ThomasBurleson
refactor(api): use Renderer2 instead of Renderer
5d6b7a3 
* Use Renderer2 instead of Renderer
* Do not extend the Angular base directives, but instead inject them into the constructor.
* improve support for future releases of Angular 5

Fixes #326.
@ThomasBurleson ThomasBurleson added has pr A PR has been created to address this issue and removed in-progress labels Aug 9, 2017
ThomasBurleson added a commit that referenced this issue Aug 9, 2017
@ThomasBurleson
refactor(api): use Renderer2 instead of Renderer
1894ec4 
* Use Renderer2 instead of Renderer
* Do not extend the Angular base directives, but instead inject them into the constructor.
* improve support for future releases of Angular 5

Fixes #326.
mmalerba pushed a commit that referenced this issue Aug 10, 2017
@ThomasBurleson @mmalerba
refactor(api): use Renderer2 instead of Renderer (#372)
695bf37 
* fix(api): getDisplayStyle() defaults to 'inline'

* refactor(api): use Renderer2 instead of Renderer

* Use Renderer2 instead of Renderer
* Do not extend the Angular base directives, but instead inject them into the constructor.
* improve support for future releases of Angular 5

Fixes #326.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
has pr A PR has been created to address this issue P1 Urgent issue that should be resolved before the next re-lease
Projects
None yet
Milestone
v2.0.0-beta.9
Development

Successfully merging a pull request may close this issue.

refactor(api): use Renderer2 instead of Renderer angular/flex-layout
2 participants
@matsko @ThomasBurleson