fix(input): continue checking for input child after initialization #4569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
reviewed
May 15, 2017
| ids.push(startHint.id); | ||
| } else if (this._hintLabel) { | ||
| ids.push(this._hintLabelId); | ||
| if (this._mdInputChild) { |
There was a problem hiding this comment.
Do we need this if? It will error on _validateInputChild before getting to this
There was a problem hiding this comment.
We do. This one seems to fire before the validation has had a chance to run.
src/lib/input/input-container.ts
Outdated
| throw new MdInputContainerMissingMdInputError(); | ||
| } | ||
|
|
||
| this._validateInputChild(); |
There was a problem hiding this comment.
not really related to this PR, but I see _prefixChildren and suffixChildren are unused, want to just get rid of them?
There was a problem hiding this comment.
crisbeto
force-pushed
the
4551/input-presence-revalidate
branch
from
92f5c1e
to
b0f4196
Compare
|
Rebased and addressed the feedback @mmalerba. |
mmalerba
added
pr: lgtm
action: merge
|
lgtm |
Currently we only check if an `md-input-container` has a child upon initialization, however the child might be removed via `ngIf` at a later point. If that happens, we eventually run into some check that assumed that we have an input child, however it would be better if we threw the appropriate error. These changes add extra validation that ensure that the input continues to be in place after init. Fixes angular#4551.
crisbeto
force-pushed
the
4551/input-presence-revalidate
branch
from
b0f4196
to
021b62d
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only check if an
md-input-containerhas a child upon initialization, however the child might be removed viangIfat a later point. If that happens, we eventually run into some check that assumed that we have an input child, however it would be better if we threw the appropriate error. These changes add extra validation that ensure that the input continues to be in place after init.Fixes #4551.