feat: add initial sass typography API #4162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Adds an initial implementation for the API that'll be used to do the Material typography.
jelbourn
reviewed
Apr 19, 2017
| @return map-get(map-get($config, $level), $name); | ||
| } | ||
|
|
||
| // Returns the font size for a level inside a typography config. |
There was a problem hiding this comment.
Returns -> Gets here and elsewhere
| $font-weight: mat-font-weight($config, $level); | ||
| $line-height: mat-line-height($config, $level); | ||
|
|
||
| font: $font-weight #{$font-size}/#{$line-height} unquote(map-get($config, font-family)); |
There was a problem hiding this comment.
Add a comment for what's going on here?
|
Addressed the feedback. |
willshowell
reviewed
Apr 20, 2017
| $font-family: mat-font-family($config); | ||
|
|
||
| // Use the shorthand `font` to represent a typography level, because it's the shortest. Notes that | ||
| // we need to use interpolation for `font-size/line-height` in order to prevent SASS from diving |
|
LGTM, can add merge-ready when you're ready |
Closed
|
When are you intending to have this be usable by the other material libraries in this repo and by user code? This looks promising! |
|
is there any example or doc reference for this feature? |
|
There's a guide at https://material.angular.io/guide/typography |
|
@crisbeto, thanks. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an initial implementation for the API that'll be used to do the Material typography.
Note: These are just the various functions and mixins, they aren't being used anywhere yet. The usage for the
mat-typographymixin can be: