fix(material/core): change ng-add to use mat.theme #29990
Conversation
andrewseguin
requested review from
crisbeto and
wagnermaciel
and removed request for
a team
andrewseguin
added
the
target: rc
|
|
||
| // Comment out the line below if you want to use the pre-defined typography utility classes. | ||
| // For more information: https://material.angular.io/guide/typography#using-typography-styles-in-your-application. | ||
| // @include mat.typography-hierarchy($${name}-theme); |
There was a problem hiding this comment.
Is there an equivalent for these optional bits with the new system? Or are we changing to a more opinionated stance of either automatically including these as part of the new mixin or just recommending not to use them?
There was a problem hiding this comment.
I prefer recommending that clients just depend on the system variables where they want them. For example they can make their own custom setup like:
h1 {
font: var(--mat-sys-headline-large);
}
h2 {
font: var(--mat-sys-headline-medium);
}
h3 {
font: var(--mat-sys-headline-small);
}
My hope is that we can get folks to generally just need to know about mat.theme and the available variables. This also seems to match with Material's departure from their previous opinionated typography names: https://m2.material.io/develop/web/guides/typography
* fix(material/core): change ng-add to use mat.theme * fix(material/core): tests --------- Co-authored-by: Andrew Seguin <andrewseguin@google.com> (cherry picked from commit 0a5b036)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.