Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/button): anchor not handling disabledInteractive correctly #29938

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 29, 2024

Fixes that the anchor-based MatButton wasn't setting aria-disabled when disabledInteractive is enabled.

Fixes #29923.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Oct 29, 2024
@crisbeto crisbeto requested a review from a team as a code owner October 29, 2024 11:44
@crisbeto crisbeto requested review from mmalerba and andrewseguin and removed request for a team October 29, 2024 11:44
Fixes that the anchor-based `MatButton` wasn't setting `aria-disabled` when `disabledInteractive` is enabled.
@crisbeto crisbeto force-pushed the 29923/anchor-disabled-interactive branch from 4bc0d43 to 7fd21be Compare October 29, 2024 16:08
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 30, 2024
@crisbeto crisbeto merged commit 6b3a371 into angular:main Oct 30, 2024
22 of 24 checks passed
crisbeto added a commit that referenced this pull request Oct 30, 2024
…ly (#29938)

Fixes that the anchor-based `MatButton` wasn't setting `aria-disabled` when `disabledInteractive` is enabled.

(cherry picked from commit 6b3a371)
crisbeto added a commit that referenced this pull request Oct 30, 2024
…ly (#29938)

Fixes that the anchor-based `MatButton` wasn't setting `aria-disabled` when `disabledInteractive` is enabled.

(cherry picked from commit 6b3a371)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(MatAnchor): aria-disabled not applied with disabledInteractive
2 participants