feat(material/core): namespace m2-specific theming APIs #28892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
detected: breaking change
crisbeto
force-pushed
the
m3-theming
branch
3 times, most recently
from
9b867dd to
ab7f7d4
Compare
crisbeto
requested review from
andrewseguin,
devversion,
mmalerba and
jelbourn
as code owners
andrewseguin
approved these changes
Apr 17, 2024
These changes rename the theming APIs that are specific to M2 to be prefixed with `m2-`. Subsequent changes will move the M3 APIs out of `experimental` and introduce a schematic to automatically migrate users. BREAKING CHANGE: The following APIs have been renamed. If you update using `ng update`, your app will be fixed automatically. * `define-light-theme` to `m2-define-light-theme` * `define-dark-theme` to `m2-define-dark-theme` * `define-palette` to `m2-define-palette` * `get-contrast-color-from-palette` to `m2-get-contrast-color-from-palette` * `get-color-from-palette` to `m2-get-color-from-palette` * `get-color-config` to `m2-get-color-config` * `get-typography-config` to `m2-get-typography-config` * `get-density-config` to `m2-get-density-config` * `$red-palette` to `$m2-red-palette` * `$pink-palette` to `$m2-pink-palette` * `$indigo-palette` to `$m2-indigo-palette` * `$purple-palette` to `$m2-purple-palette` * `$deep-purple-palette` to `$m2-deep-purple-palette` * `$blue-palette` to `$m2-blue-palette` * `$light-blue-palette` to `$m2-light-blue-palette` * `$cyan-palette` to `$m2-cyan-palette` * `$teal-palette` to `$m2-teal-palette` * `$green-palette` to `$m2-green-palette` * `$light-green-palette` to `$m2-light-green-palette` * `$lime-palette` to `$m2-lime-palette` * `$yellow-palette` to `$m2-yellow-palette` * `$amber-palette` to `$m2-amber-palette` * `$orange-palette` to `$m2-orange-palette` * `$deep-orange-palette` to `$m2-deep-orange-palette` * `$brown-palette` to `$m2-brown-palette` * `$grey-palette` to `$m2-grey-palette` * `$gray-palette` to `$m2-gray-palette` * `$blue-grey-palette` to `$m2-blue-grey-palette` * `$blue-gray-palette` to `$m2-blue-gray-palette` * `$light-theme-background-palette` to `$m2-light-theme-background-palette` * `$dark-theme-background-palette` to `$m2-dark-theme-background-palette` * `$light-theme-foreground-palette` to `$m2-light-theme-foreground-palette` * `$dark-theme-foreground-palette` to `$m2-dark-theme-foreground-palette` * `define-typography-level` to `m2-define-typography-level` * `define-rem-typography-config` to `m2-define-rem-typography-config` * `define-typography-config` to `m2-define-typography-config` * `define-legacy-typography-config` to `m2-define-legacy-typography-config` * `typography-level` to `m2-typography-level` * `font-size` to `m2-font-size` * `line-height` to `m2-line-height` * `font-weight` to `m2-font-weight` * `letter-spacing` to `m2-letter-spacing` * `font-family` to `m2-font-family` * `font-shorthand` to `m2-font-shorthand`
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 18, 2024
…e directory Moves all of the M2-specific public theming APIs into a separate directory so they're easier to distinguish and so they don't interfere when we move the M3 APIs from experimental. This shouldn't affect users since namespacing already happened as a part of angular#28892.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 18, 2024
…e directory Moves all of the M2-specific public theming APIs into a separate directory so they're easier to distinguish and so they don't interfere when we move the M3 APIs from experimental. This shouldn't affect users since namespacing already happened as a part of angular#28892.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 18, 2024
…e directory Moves all of the M2-specific public theming APIs into a separate directory so they're easier to distinguish and so they don't interfere when we move the M3 APIs from experimental. This shouldn't affect users since namespacing already happened as a part of angular#28892.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 18, 2024
…e directory Moves all of the M2-specific public theming APIs into a separate directory so they're easier to distinguish and so they don't interfere when we move the M3 APIs from experimental. This shouldn't affect users since namespacing already happened as a part of angular#28892.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 22, 2024
Adds a migration to account for the breaking changes in angular#28892. The migration changes all the places where functions and variables were renamed, as well as the usages of experimental APIs that were moved into stable.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 22, 2024
Adds a migration to account for the breaking changes in angular#28892. The migration changes all the places where functions and variables were renamed, as well as the usages of experimental APIs that were moved into stable.
crisbeto
added a commit
that referenced
this pull request
Apr 23, 2024
Adds a migration to account for the breaking changes in #28892. The migration changes all the places where functions and variables were renamed, as well as the usages of experimental APIs that were moved into stable.
This was referenced May 16, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes rename the theming APIs that are specific to M2 to be prefixed with
m2-. Subsequent changes will move the M3 APIs out ofexperimentaland introduce a schematic to automatically migrate users.BREAKING CHANGE:
The following APIs have been renamed. If you update using
ng update, your app will be fixed automatically.define-light-themetom2-define-light-themedefine-dark-themetom2-define-dark-themedefine-palettetom2-define-paletteget-contrast-color-from-palettetom2-get-contrast-color-from-paletteget-color-from-palettetom2-get-color-from-paletteget-color-configtom2-get-color-configget-typography-configtom2-get-typography-configget-density-configtom2-get-density-config$red-paletteto$m2-red-palette$pink-paletteto$m2-pink-palette$indigo-paletteto$m2-indigo-palette$purple-paletteto$m2-purple-palette$deep-purple-paletteto$m2-deep-purple-palette$blue-paletteto$m2-blue-palette$light-blue-paletteto$m2-light-blue-palette$cyan-paletteto$m2-cyan-palette$teal-paletteto$m2-teal-palette$green-paletteto$m2-green-palette$light-green-paletteto$m2-light-green-palette$lime-paletteto$m2-lime-palette$yellow-paletteto$m2-yellow-palette$amber-paletteto$m2-amber-palette$orange-paletteto$m2-orange-palette$deep-orange-paletteto$m2-deep-orange-palette$brown-paletteto$m2-brown-palette$grey-paletteto$m2-grey-palette$gray-paletteto$m2-gray-palette$blue-grey-paletteto$m2-blue-grey-palette$blue-gray-paletteto$m2-blue-gray-palette$light-theme-background-paletteto$m2-light-theme-background-palette$dark-theme-background-paletteto$m2-dark-theme-background-palette$light-theme-foreground-paletteto$m2-light-theme-foreground-palette$dark-theme-foreground-paletteto$m2-dark-theme-foreground-palettedefine-typography-leveltom2-define-typography-leveldefine-rem-typography-configtom2-define-rem-typography-configdefine-typography-configtom2-define-typography-configdefine-legacy-typography-configtom2-define-legacy-typography-configtypography-leveltom2-typography-levelfont-sizetom2-font-sizeline-heighttom2-line-heightfont-weighttom2-font-weightletter-spacingtom2-letter-spacingfont-familytom2-font-familyfont-shorthandtom2-font-shorthand