-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/list): nav list item border-radius #28789
Conversation
wagnermaciel
commented
Mar 27, 2024
- https://m2.material.io/components/navigation-drawer#states
- https://m3.material.io/components/navigation-drawer/specs
Deployed dev-app for e6e6614 to: https://ng-dev-previews-comp--pr-angular-components-28789-dev-brlh8s9b.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list change LGTM. I wonder if we don't need to make a change to either the inner padding of the list or the sidenav since it currently looks a bit weird because it's edge-to-edge 🤔
I was wondering this too. I think we do want this, but that change is probably so breaking that I'll want to do it in a separate PR 😭 Also, I never knew about that dev-app-preview label. That is awesome! |
I think that if we scope it to only nav lists inside sidenavs on M3 it shouldn't be too breaking. |
* fix(material/list): nav list item border-radius * https://m2.material.io/components/navigation-drawer#states * https://m3.material.io/components/navigation-drawer/specs * fixup! fix(material/list): nav list item border-radius * fixup! fix(material/list): nav list item border-radius (cherry picked from commit 7165a45)
@karmasakshi Hi Karma, yes this is intentional. Here's what the m2 nav list (or navigation drawer as Material Design calls it) is meant to look like |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |