Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk/a11y): support signals in ListKeyManager #28757

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

crisbeto
Copy link
Member

Updates the ListKeyManager to support passing in a signal. Also expands the type to allow readonly arrays.

Fixes #28710.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Mar 21, 2024
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Updates the `ListKeyManager` to support passing in a signal. Also expands the type to allow readonly arrays.

Fixes angular#28710.
@crisbeto crisbeto force-pushed the 28710/list-key-manager-signals branch from 75bfecd to fed5564 Compare March 21, 2024 08:20
@crisbeto crisbeto removed the request for review from jelbourn March 21, 2024 08:42
@crisbeto crisbeto self-assigned this Mar 21, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 21, 2024
@crisbeto crisbeto merged commit da980a8 into angular:main Mar 21, 2024
23 of 26 checks passed
crisbeto added a commit that referenced this pull request Mar 21, 2024
Updates the `ListKeyManager` to support passing in a signal. Also expands the type to allow readonly arrays.

Fixes #28710.

(cherry picked from commit da980a8)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(ListKeyManager): Support Signal-based Query
2 participants