-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/datepicker): datepicker doesn't announce newly selected range in firefox #28529
fix(material/datepicker): datepicker doesn't announce newly selected range in firefox #28529
Conversation
Before screencast: After screencast: Note: tested successful description updates after changes on Safari (VoiceOver), Chrome (VoiceOver), Firefox (VoiceOver), Firefox (NVDA). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, it would be good to have a code comment explaining why the label is included in a11y tree.
Could you file an issue report on Firefox for this? @essjay05 looked together and were unable to make a minimal reproduction. We can use our Stackblitz environment to create a reproduction for the issue report. Out Stackblitz template is at https://stackblitz.com/fork/components-issue
Sounds good. Will add the note and file an issue report in Firefox. |
…'t announce selected year range Fixes a bug in the Angular Material component where when the selected year range is updated by moving foward to the next range or by moving to the previous range the screenreader announces the original date range rather than the newly selected date range. This because the class was removing the new value from the Firefox accessibility tree. Fixes angular#28360
569463b
to
2227150
Compare
Deployed dev-app for 62f5a68 to: https://ng-dev-previews-comp--pr-angular-components-28529-dev-s03a4tjk.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
…r doesn't announce selected year range Adds comment in html file to connect the filed Firefox issue with the workaround. Fixes angular#28360
f8adcd1
to
62f5a68
Compare
…range in firefox (#28529) * fix(material/datepicker): multi-year view changes in datepicker doesn't announce selected year range Fixes a bug in the Angular Material component where when the selected year range is updated by moving foward to the next range or by moving to the previous range the screenreader announces the original date range rather than the newly selected date range. This because the class was removing the new value from the Firefox accessibility tree. Fixes #28360 * !fixup fix(material/datepicker): multi-year view changes in datepicker doesn't announce selected year range Adds comment in html file to connect the filed Firefox issue with the workaround. Fixes #28360 (cherry picked from commit c72add6)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes a bug in the Angular Material component where when the selected year range is updated by moving forward to the next range or by moving to the previous range the screenreader announces the original date range rather than the newly selected date range. This is because the label class was removing the updated value from the Firefox accessibility tree.
Fixes #28360