docs(material/dialog): use h2 for dialog title #28519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerKiKi
requested review from
mmalerba,
andrewseguin and
devversion
as code owners
PowerKiKi
force-pushed
the
dialog-title
branch
from
f61e8fe to
e5a67f9
Compare
PowerKiKi
force-pushed
the
dialog-title
branch
from
e5a67f9 to
317d551
Compare
crisbeto
approved these changes
Feb 1, 2024
PowerKiKi
force-pushed
the
dialog-title
branch
from
317d551 to
124739a
Compare
|
Are browserstack tests flaky ? or did I indeed broke something ? |
|
I think it's a flake, but I'll restart it just in case. |
crisbeto
added
action: merge
|
@PowerKiKi it looks like this needs to be rebased. |
Because the vast majority of pages will already have an `<h1>`, and MDN now recommends to avoid using multiple `<h1>` elements on one page. So we should strive to show code examples that can be copy-pasted as is. See also: - https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements#avoid_using_multiple_h1_elements_on_one_page - https://stackoverflow.com/a/38467898/37706 - https://accessibleweb.com/question-answer/how-should-i-handle-headings-in-a-modal/
PowerKiKi
force-pushed
the
dialog-title
branch
from
124739a to
53c64c7
Compare
|
rebased |
crisbeto
approved these changes
Feb 1, 2024
crisbeto
pushed a commit
that referenced
this pull request
Feb 1, 2024
Because the vast majority of pages will already have an `<h1>`, and MDN now recommends to avoid using multiple `<h1>` elements on one page. So we should strive to show code examples that can be copy-pasted as is. See also: - https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements#avoid_using_multiple_h1_elements_on_one_page - https://stackoverflow.com/a/38467898/37706 - https://accessibleweb.com/question-answer/how-should-i-handle-headings-in-a-modal/ (cherry picked from commit 14d5de1)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the vast majority of pages will already have an
<h1>, and MDN now recommends to avoid using multiple<h1>elements on one page. So we should strive to show code examples that can be copy-pasted as is.See also: