Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDC table last row within tbody set bottom border as none for header … #27762

Closed
wants to merge 5 commits into from

Conversation

prajapatimadan
Copy link

…cell as other mat-mdc-cell bottom border are set as none, this will make consistent layout for table.

Also referring "bug(material/table): last row border inconsistency #27731"

…cell as other mat-mdc-cell bottom border are set as none, this will make consistent layout for table
@google-cla
Copy link

google-cla bot commented Sep 5, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@prajapatimadan
Copy link
Author

Please suggest any steps required to complete the review process, so that PR can approve.

Copy link
Author

@prajapatimadan prajapatimadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewseguin , This CSS changes, will resolve the table layout consistency issue and not impact on any other table component functionalities. Please have a look

@andreroggeri
Copy link
Contributor

@prajapatimadan I believe you tagged the wrong person 😅

@prajapatimadan
Copy link
Author

@prajapatimadan I believe you tagged the wrong person 😅

Sorry!

@andrewseguin andrewseguin self-assigned this Oct 4, 2023
@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Dec 16, 2024
@andrewseguin
Copy link
Contributor

Closing in favor of #30193

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants