Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(material/tooltip): be able to customize the longpress delay #27512

Merged
merged 1 commit into from
Feb 29, 2024
Merged

feat(material/tooltip): be able to customize the longpress delay #27512

merged 1 commit into from
Feb 29, 2024

Conversation

dmitry-stepanenko
Copy link
Contributor

@dmitry-stepanenko dmitry-stepanenko commented Jul 26, 2023 •
edited
Loading

Right now it is not possible to customize the delay for the longpress on touch devices. Sometimesit might be desirable to use other value than 500ms, adding this as a touchLongPressShowDelay option for MAT_TOOLTIP_DEFAULT_OPTIONS

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Jul 26, 2023
@wagnermaciel wagnermaciel added feature This issue represents a new feature or feature request rather than a bug or bug fix P5 The team acknowledges the request but does not plan to address it, it remains open for discussion needs: discussion Further discussion with the team is needed before proceeding area: material/tooltip and removed detected: feature PR contains a feature commit labels Jul 26, 2023
@dmitry-stepanenko
Copy link
Contributor Author

Can you guys point me how to update your docs according to the API change that i've made? I don't see a command for that

@wagnermaciel wagnermaciel removed the P5 The team acknowledges the request but does not plan to address it, it remains open for discussion label Jul 26, 2023
@dmitry-stepanenko
Copy link
Contributor Author

@andrewseguin @wagnermaciel @crisbeto any update on this one?

crisbeto
crisbeto approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the really long delay here. The change LGTM, but can you rebase and run yarn approve-api tooltip and commit the changed file?

@dmitry-stepanenko dmitry-stepanenko force-pushed the ds/customizable-longpress-delay branch from ef07a6b to 90b623c Compare February 28, 2024 16:01
@dmitry-stepanenko
Copy link
Contributor Author

Thanks @crisbeto, done

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Feb 28, 2024
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed needs: discussion Further discussion with the team is needed before proceeding labels Feb 29, 2024
@crisbeto crisbeto removed the request for review from andrewseguin February 29, 2024 08:53
@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Feb 29, 2024
@crisbeto crisbeto self-assigned this Feb 29, 2024
@crisbeto crisbeto merged commit 26b376e into angular:main Feb 29, 2024
30 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker area: material/tooltip detected: feature PR contains a feature commit feature This issue represents a new feature or feature request rather than a bug or bug fix target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmitry-stepanenko @crisbeto @wagnermaciel