perf(material/form-field): resolve scrolling performance issues #27251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
mmalerba
approved these changes
Jun 9, 2023
src/material/form-field/_mdc-text-field-structure-overrides.scss
Outdated
Show resolved
Hide resolved
src/material/form-field/_mdc-text-field-structure-overrides.scss
Outdated
Show resolved
Hide resolved
devversion
approved these changes
Jun 12, 2023
|
Any updates on this? |
MDC was setting `will-change` on a couple of elements which caused significant scrolling performance issues on pages with a lot of form fields. These changes reset the `will-change`, because one of the elements wasn't being animated at all and the other one was only animating `transform` which is hardware-accelerated. Fixes angular#27249.
crisbeto
force-pushed
the
form-field-perf
branch
from
9106377 to
72c7f2c
Compare
crisbeto
added a commit
that referenced
this pull request
Feb 28, 2024
MDC was setting `will-change` on a couple of elements which caused significant scrolling performance issues on pages with a lot of form fields. These changes reset the `will-change`, because one of the elements wasn't being animated at all and the other one was only animating `transform` which is hardware-accelerated. Fixes #27249. (cherry picked from commit f6e8584)
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Mar 12, 2024
When `will-change` was removed in angular#27251, the form field lost its implicit stacking context which means that some of its descendants may be stacked on top of the container. These changes add an explicit `z-index` on the container to resolve the issue. Fixes angular#28708.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Mar 12, 2024
When `will-change` was removed in angular#27251, the form field lost its implicit stacking context which means that some of its descendants may be stacked on top of the container. These changes add an explicit `z-index` on the container to resolve the issue. Fixes angular#28708.
crisbeto
added a commit
that referenced
this pull request
Mar 12, 2024
…28713) When `will-change` was removed in #27251, the form field lost its implicit stacking context which means that some of its descendants may be stacked on top of the container. These changes add an explicit `z-index` on the container to resolve the issue. Fixes #28708. (cherry picked from commit ce9a395)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MDC was setting
will-changeon a couple of elements which caused significant scrolling performance issues on pages with a lot of form fields. These changes reset thewill-change, because one of the elements wasn't being animated at all and the other one was only animatingtransformwhich is hardware-accelerated.Fixes #27249.
For reference, this is before:
https://github.com/angular/components/assets/4450522/923fbb24-4984-47ba-b87b-5645fd344bf6
And this is after:
https://github.com/angular/components/assets/4450522/26565ce1-662d-4c52-b3a3-a5a209027ddb