-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(list-key-manager): active descendant support #2606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one small comment
*/ | ||
export interface Highlightable extends CanDisable { | ||
setActiveStyles(): void; | ||
setInactiveStyles(): void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about activate()
and deactivate()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For posterity: Discussed offline and we will leave
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This PR adds key management for lists where changing the focus is not desired. There are now two types of key managers: FocusKeyManager (which will set focus) and ActiveDescendantKeyManager (which will simply set active styles and manage a11y through activedescendant). The latter will be useful for an autocomplete so the text field can retain focus while iterating through the list.
r: @jelbourn