Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/slide-toggle): animations not disabled with NoopAnimationsModule #25821

Merged
merged 1 commit into from
Oct 18, 2022
Merged

fix(material/slide-toggle): animations not disabled with NoopAnimationsModule #25821

merged 1 commit into from
Oct 18, 2022

Conversation

crisbeto
Copy link
Member

Fixes that the animations of the slide toggle weren't disabled when using the NoopAnimationsModule.

@crisbeto
fix(material/slide-toggle): animations not disabled with NoopAnimatio…
87ea365 
…nsModule

Fixes that the animations of the slide toggle weren't disabled when using the `NoopAnimationsModule`.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate labels Oct 17, 2022
mmalerba
mmalerba approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Oct 18, 2022
@crisbeto crisbeto merged commit 7ede2d0 into angular:main Oct 18, 2022
crisbeto added a commit that referenced this pull request Oct 18, 2022
@crisbeto
fix(material/slide-toggle): animations not disabled with NoopAnimatio…
3c01ef3 
…nsModule (#25821)

Fixes that the animations of the slide toggle weren't disabled when using the `NoopAnimationsModule`.

(cherry picked from commit 7ede2d0)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crisbeto @mmalerba