Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/slide-toggle): align colors with spec #25792

Merged
merged 2 commits into from
Oct 12, 2022
Merged

fix(material/slide-toggle): align colors with spec #25792

merged 2 commits into from
Oct 12, 2022

Conversation

mmalerba
Copy link
Contributor

Note: the disabled state still isn't 100% right. There seems to be some opacity interaction going on that prevents matching the spec perfectly.

@mmalerba
fix(material/slide-toggle): align colors with spec
e0e24de 
Note: the disabled state still isn't 100% right. There seems to be some
opacity interaction going on that prevents matching the spec perfectly.
@mmalerba mmalerba added the target: major This PR is targeted for the next major release label Oct 11, 2022
@mmalerba mmalerba requested a review from crisbeto as a code owner October 11, 2022 20:38
wagnermaciel
wagnermaciel approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have have much knowledge here so you might want to wait for Kristiyan, but from what I understand - lgtm

crisbeto
crisbeto approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of nits

src/material/slide-toggle/_slide-toggle-theme.scss Outdated Show resolved Hide resolved
src/material/slide-toggle/_slide-toggle-theme.scss Outdated Show resolved Hide resolved
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Oct 12, 2022
@mmalerba mmalerba merged commit 19c45c5 into angular:main Oct 12, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@wagnermaciel wagnermaciel wagnermaciel approved these changes

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmalerba @crisbeto @wagnermaciel