feat(dialog): add the ability to align the content of md-dialog-actions #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the `align` attribute, which can be set to `end` or `middle`, that allows users to align the content of the `md-dialog-actions`. Fixes angular#2483.
googlebot
added
the
cla: yes
jelbourn
reviewed
Jan 12, 2017
| @@ -37,7 +37,7 @@ A reference to the dialog created by the MdDialog `open` method. | |||
| | `md-dialog-title` | Marks the title of the dialog. | |||
| | `md-dialog-content` | Scrollable content of the dialog. | |||
| | `md-dialog-close` | When added to a `button`, makes the element act as a close button for the dialog. | |||
| | `md-dialog-actions` | Wrapper for the set of actions at the bottom of a dialog. Typically contains buttons. | |||
| | `md-dialog-actions` | Wrapper for the set of actions at the bottom of a dialog. Typically contains buttons. The element's content can be aligned via the `align` attribute either to the `middle` or the `end`. | | |||
There was a problem hiding this comment.
Should be center rather than middle.
|
|
||
| &:last-child { | ||
| // If the actions are the last element in a dialog, we need to pull them down | ||
| // over the dialog padding, in order to avoid the action's padding stacking | ||
| // with the dialog's. | ||
| margin-bottom: -$md-dialog-padding; | ||
| } | ||
|
|
||
| &[align='end'] { |
There was a problem hiding this comment.
If someone sets align with a binding ([align]="buttonAlignment")` does it still apply this attribute?
There was a problem hiding this comment.
It does. That's what I did in the playground/demo app.
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
alignattribute, which can be set toendormiddle, that allows users to align the content of themd-dialog-actions.Fixes #2483.