Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/table): cleanup legacy usage #25525

Merged
merged 1 commit into from
Aug 25, 2022
Merged

fix(material/table): cleanup legacy usage #25525

merged 1 commit into from
Aug 25, 2022

Conversation

andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Aug 24, 2022 •
edited
Loading

Cleanup various places where the legacy table was still present - Swapped where the harness tests were located (previously still in legacy)

@andrewseguin andrewseguin added the target: major This PR is targeted for the next major release label Aug 24, 2022
@andrewseguin andrewseguin force-pushed the e2e branch 2 times, most recently from b6f8791 to 2f9c816 Compare August 25, 2022 11:29
@andrewseguin andrewseguin marked this pull request as ready for review August 25, 2022 15:22
wagnermaciel
wagnermaciel approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker merge safe labels Aug 25, 2022
@andrewseguin andrewseguin merged commit eafea52 into angular:main Aug 25, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewseguin @wagnermaciel