feat(material/core): move MDC-based elevation styles out of experimental #25486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
force-pushed
the
mdc-elevation
branch
from
08f9cd4 to
1e01de2
Compare
mmalerba
force-pushed
the
mdc-elevation
branch
from
3188791 to
3cd5830
Compare
crisbeto
approved these changes
Aug 19, 2022
| @@ -549,7 +549,7 @@ export class _MatMenuBase | |||
| providers: [{provide: MAT_MENU_PANEL, useExisting: MatMenu}], | |||
| }) | |||
| export class MatMenu extends _MatMenuBase { | |||
| protected override _elevationPrefix = 'mat-mdc-elevation-z'; | |||
There was a problem hiding this comment.
nit: this is now the same as the legacy version so we can remove the _elevationPrefix and just hardcode it in the base class.
There was a problem hiding this comment.
Yeah I plan to clean this up more in a followup PR. I reverted some changes in this PR to narrow down failures in TAP
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.