-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(material/snack-bar): Switch snack-bar implementation to use MDC #25458
Conversation
6d8a7f7
to
3e70e0b
Compare
@crisbeto do you know whats up with this test failure: "theming api should warn if default density styles are duplicated" It looks like the mdc-button density styles are missing. I did touch those styles a bit because I found that button density was under "unmigrated-component-densities" and icon-button, fab were just missing. I'm not sure why the test is failing though. If anything my change should have fixed it since it added the missing mixins |
I would have to dig into why that test is failing, but from what I can tell, it is related to MDC's styles, because excluding this mixin fixes the test failure https://github.com/angular/components/blob/main/src/material/button/_icon-button-theme.scss#L55. Maybe it's being generated under the wrong selector? |
Yeah I remember getting that when I had the wrong names in |
7cf6931
to
92e752b
Compare
Based on my understanding of the test, it looks like |
92e752b
to
b63f32b
Compare
Mystery solved: the function we had to compare CSS output didn't know how to handle comments, which was causing it to say that the outputs weren't equivalent |
3fc17e4
to
8bbf672
Compare
Old implementation is still available under @angular/material/legacy-snack-bar BREAKING CHANGE: - DOM and CSS classes for mat-snack-bar have changes - Typescript API is largely the same but may have minor differences - See the MDC migration guide for more information about the changes and how to migrate your app (TODO: link when available)
8bbf672
to
5098933
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Old implementation is still available under @angular/material/legacy-snack-bar
BREAKING CHANGE:
how to migrate your app (TODO: link when available)