-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/datepicker): calendar aria-descriptions start/end date #25457
Conversation
e99bd68
to
4a8580f
Compare
This is pretty far along, but still a draft. Here's the remaining TODO's to make this ready:
|
4a8580f
to
8ab5e84
Compare
8ab5e84
to
38792a6
Compare
314b631
to
b943338
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@crisbeto my thought process here is that I recommend using tomorrow, I can take a look at |
I was mostly referring to setting the accepted types to |
Okay, we can do that, we would also need to change this line that detects input element to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b943338
to
f807adb
Compare
For date ranges, add aria-descriptions to the cell of the current start date and also for end date. Popuplate aria descriptions with the expected value of the ARIA accessible name of the `matStartDate` and `matEndDate` inputs. Introduces `_computeAriaAccessibleName` function to implement ARIA acc-name-1.2 specificiation. Fixes angular#23442 and angular#23445
f807adb
to
b85f75a
Compare
…ngular#25457) For date ranges, add aria-descriptions to the cell of the current start date and also for end date. Popuplate aria descriptions with the expected value of the ARIA accessible name of the `matStartDate` and `matEndDate` inputs. Introduces `_computeAriaAccessibleName` function to implement ARIA acc-name-1.2 specificiation. Fixes angular#23442 and angular#23445
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
For date ranges, add aria-descriptions to the cell of the current start
date and also for end date.
Popuplate aria descriptions with the expected value of the ARIA accessible name of the
matStartDate
andmatEndDate
inputs. Introduces_computeAriaAccessibleName
function toimplement ARIA acc-name-1.2 specificiation.
Fixes #23442 and #23445