Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/overlay): remove Optional decorator in ConnectedOverlayPositionChange constructor #23735

Merged
merged 1 commit into from
Nov 9, 2021
Merged

fix(cdk/overlay): remove Optional decorator in ConnectedOverlayPositionChange constructor #23735

merged 1 commit into from
Nov 9, 2021

Conversation

trik
Copy link
Contributor

@trik trik commented Oct 12, 2021 •
edited
Loading

fix(cdk/overlay): remove Optional decorator in ConnectedOverlayPositionChange constructor

@trik trik requested review from crisbeto, jelbourn and a team as code owners October 12, 2021 11:15
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 12, 2021
@trik trik force-pushed the connected-overlay-position-change-decorator branch from cfaee5d to 9cac963 Compare October 12, 2021 11:20
crisbeto
crisbeto reviewed Oct 12, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this is the correct fix. We should remove the Optional from the constructor instead.

@trik trik force-pushed the connected-overlay-position-change-decorator branch from 9cac963 to 447b956 Compare October 12, 2021 16:30
@trik trik changed the title fix(cdk/overlay): add @Injectable to ConnectedOverlayPositionChange fix(cdk/overlay): remove Optional decorator in ConnectedOverlayPositionChange constructor Oct 12, 2021
@trik trik requested review from crisbeto and removed request for a team October 12, 2021 16:31
@trik trik force-pushed the connected-overlay-position-change-decorator branch from 447b956 to 6342f1a Compare October 12, 2021 16:32
crisbeto
crisbeto approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Oct 13, 2021
@trik trik force-pushed the connected-overlay-position-change-decorator branch 2 times, most recently from bf5b03d to b5ad302 Compare October 21, 2021 09:51
@trik trik force-pushed the connected-overlay-position-change-decorator branch from b5ad302 to 02240b9 Compare October 21, 2021 09:57
@amysorto amysorto merged commit 1267263 into angular:master Nov 9, 2021
amysorto pushed a commit that referenced this pull request Nov 9, 2021
@trik @amysorto
fix(cdk/overlay): remove Optional decorator in ConnectedOverlayPositi…
36fa18b 
…onChange constructor (#23735)

(cherry picked from commit 1267263)
@trik trik deleted the connected-overlay-position-change-decorator branch November 9, 2021 17:45
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trik @crisbeto @amysorto