Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to TypeScript 3.1 #13384

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Oct 2, 2018

With TypeScript 3.1, several native DOM types have been updated. Notably, document.documentElement and document.activeElement are now nullable. APIs relating to matchMedia were also updated.

This change is necessary for v7 RC

@jelbourn jelbourn added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: major This PR is targeted for the next major release labels Oct 2, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 2, 2018
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto
Copy link
Member

crisbeto commented Oct 2, 2018

Looks like there's an error in one of the unit tests.

@jelbourn jelbourn force-pushed the release-rc branch 2 times, most recently from 0d17d8a to 7612b99 Compare October 2, 2018 16:00
@jelbourn
Copy link
Member Author

jelbourn commented Oct 2, 2018

Fixed unit test

@jelbourn
Copy link
Member Author

jelbourn commented Oct 2, 2018

I made one other change in breakpoint-observer.ts to make this build in Google, which isn't on TypeScript 3.1 yet

With TypeScript 3.1, several native DOM types have been updated. Notably, `document.documentElement` and `document.activeElement` are now nullable. APIs relating to `matchMedia` were also updated.
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Oct 2, 2018
@jelbourn jelbourn merged commit c9681bf into angular:master Oct 2, 2018
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
With TypeScript 3.1, several native DOM types have been updated. Notably, `document.documentElement` and `document.activeElement` are now nullable. APIs relating to `matchMedia` were also updated.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants