Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(textarea): create textarea #1282

Closed
wants to merge 8 commits into from

Conversation

dharmeshpipariya-zz
Copy link

creates the md-textarea feature 546

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 20, 2016
@jelbourn
Copy link
Member

@dharmeshpipariya it will probably be a bit before we can review this; we're all tied up preparing for Angular Connect next week.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Sep 22, 2016
@jelbourn
Copy link
Member

@dharmeshpipariya It looks like this is mostly copy-and-paste from md-input without any refactoring to reuse common parts between them. This kind of approach has a higher cost in the long run because you're now maintaining two sets of code that do the same thing. The two components should share code, potentially even being the same component with some conditionals. I'm going to close this PR since, at a high level, it's not really the way we want to approach the implementation. If you want to try a different approach, comment on #546 with your plan and we can discuss further.

@jelbourn jelbourn closed this Oct 19, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants