fix(button-toggle): toggle group should not emit an initial change event.

[devversion]

This is the addition of 23a61ab, which was only taking care of the ButtonToggle itself, and not of the group.

Since the md-button-toggle-group does not contain any underlaying input element, and we can't use the emit event if native input does approach, we need to wait for the component view to be ready.

References #1125

[colinfang]

Just wondering, can we put this._isInitialized = true in ngOnInit? As the property bindings are finished before entering ngOnInit.

[devversion]

@colinfang Yeah that works too. I do not recall why we started using the ngAfterViewInit hook instead.

[jelbourn]

@devversion @colinfang Using ngOnInit does not work because the order of initialization for directives on the same element is not defined. As such, an ngModel on the element may initialize after the ngOnInit of the component itself.

[devversion]

@jelbourn Sounds reasonable. Reverted my commit about the ngOnInit

[jelbourn]

LGTM

[colinfang]

@jelbourn Sorry I don't quite follow up, I have never made a ngModel for a custom component before. Could you please elaborate a little bit more?

Are you saying in

 <my-component  [ngModel]="abc" ></my-component>

At MyComponent.ngOnInit, the value of myInput may not be assigned if ngModel is mapped to a property say Output() myInput?

[jelbourn]

@colinfang when you have an ngModel, it can be responsible for initializing the component, so you want to set isInitialized = true after ngModel has run, which can be after the component's onInit.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}