Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md-input placeholder text is partially hidden #795

Closed
Saegrov opened this issue Jul 1, 2016 · 10 comments · Fixed by #871
Closed

md-input placeholder text is partially hidden #795

Saegrov opened this issue Jul 1, 2016 · 10 comments · Fixed by #871
Labels
P2 The issue is important to a large percentage of users, with a workaround
Milestone

Comments

@Saegrov
Copy link

Saegrov commented Jul 1, 2016

Bug, feature request, or proposal:

Bug introduced in the latest alpha-6. I'm not sure if I'm using it wrong or if this is expected behaviour.

What is the expected behavior?

Current behaviour in alpha-5
expected

What is the current behavior?

After upgrading to alpha-6
bug

What are the steps to reproduce?

Using md-input.

Which versions of Angular, Material, OS, browsers are affected?

Using Angular RC-3, Material alpha-6.
It's affected in Safari, Firefox and Chrome on OSX. Haven't tested other browsers.

Is there anything else we should know?

Introduced in the following commit: cf2703c
Disabling the overflow: hidden on the :hostselector for md-input solves the issues.

screen shot 2016-07-01 at 11 58 38

@Saegrov Saegrov changed the title md-input placeholder is partially hidden whe md-input placeholder text is partially hidden Jul 1, 2016
@ghost
Copy link

ghost commented Jul 1, 2016

Doesn't seem to happen on Chrome / Firefox / Edge in Windows (Angular2 RC4 & Material2 alpha 6)

@Saegrov
Copy link
Author

Saegrov commented Jul 5, 2016

I'll see if I can make a plunkr or repo to reproduce it. Is there any plunkr template that has the latest alpha? The one in the Readme seems to have the alpha-5: http://plnkr.co/edit/o077B6uEiiIgkC0S06dd?p=preview

@DzmitryShylovich
Copy link

DzmitryShylovich commented Jul 5, 2016

@Zyzle
Copy link

Zyzle commented Jul 5, 2016

I'm seeing a similar behaviour with the hint labels after upgrading to alpha-6 but cant seem to reproduce it in @DzmitryShylovich's plunk it is however present on the material demo app.

@Saegrov
Copy link
Author

Saegrov commented Jul 5, 2016

@DzmitryShylovich Are you sure this includes the latest input? It seems the overflow:hidden property isn't on the md-input element in the plunkr.

I created a repo to demonstrate it:
https://github.com/Saegrov/angular-2-input-bug
Edit: I've hosted an example here: http://temp-github-issue.s3-website-eu-west-1.amazonaws.com/

Apologies for the large repo to demonstrate a rather small bug (i just used the angular-2-webpack-starter).

@RoxKilly
Copy link

RoxKilly commented Jul 6, 2016

I observe the same thing with input hints. I'm using Angular RC4, Material Alpha 6, on Firefox 48 Beta.
4
I can also confirm that removing overflow:hidden rule from <md-input> resolves the issue

@msegers
Copy link

msegers commented Jul 6, 2016

Same here, I just currently slapped a md-input { overflow: visible !important; } in my css.

@PascalTemel
Copy link

I'm experiencing the issue with hidden hint labels aswell.

@jelbourn jelbourn added the P2 The issue is important to a large percentage of users, with a workaround label Jul 14, 2016
@jelbourn jelbourn added this to the alpha.8 milestone Jul 14, 2016
kara added a commit to kara/material2 that referenced this issue Jul 16, 2016
@kara
Copy link
Contributor

kara commented Jul 16, 2016

@Saegrov I can confirm this is cut off in iOS Safari as well. The fix you suggested seems right at first glance (@hansl will have to take a look). Just submitted a quick PR with the change: #871.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants