Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sidenav] - add support for 'backdrop' as optional input #5300

Closed
Lior-G opened this issue Jun 22, 2017 · 5 comments · Fixed by #9381
Closed

[Sidenav] - add support for 'backdrop' as optional input #5300

Lior-G opened this issue Jun 22, 2017 · 5 comments · Fixed by #9381
Assignees
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@Lior-G
Copy link

Lior-G commented Jun 22, 2017

Bug, feature request, or proposal:

I would like to suggest to have 'backdrop' as an optional input for Sidenav compoment.
Default would be true for 'mode' = 'over' or 'push', and false for 'side'

What is the expected behavior?

if 'backdrop' input is provided, to overwrite the default; and show/hide backdrop accordingly

What is the current behavior?

Backdrop exists for 'mode' = 'over' or 'push', and does not exist for 'side'

What are the steps to reproduce?

current documentation on Sidenav:
https://material.angular.io/components/sidenav/overview

What is the use-case or motivation for changing an existing behavior?

Give user the flexibility to not have 'backdrop' on 'mode' = 'over' or 'push' or do have it on 'side'

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

"@angular/core": "4.2.0-beta.0",
"@angular/material": "^2.0.0-beta.3",
"typescript": "~2.3.2"

Is there anything else we should know?

this change would be appreciated

@Lior-G
Copy link
Author

Lior-G commented Jun 22, 2017

I noticed this is related (not duplicate) to #4482

@kaylucas
Copy link

I'm looking for the same feature. We're using the sidenav for a mapping application where the sidenav is opening over the map. If the backdrop could be disabled this would give the user the ability to pan/click items on the map while having the sidenav open. Now it's disabling the map usage and users have to click out of it. I could use the 'side' mode but it's not working very well on mobile and it makes the map look strange because it compresses the width.

@thw0rted
Copy link

This is supported by the spec. The same sidenav should be usable for "permanent", "persistent", or "temporary" navigation drawers. Right now the "over" mode works well for "temporary" but I don't see any way to do "persistent", which is what I think @kaylucas is looking for.

@TobiasVdb
Copy link

+1

@mmalerba mmalerba added feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Nov 21, 2017
@crisbeto crisbeto self-assigned this Jan 13, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 13, 2018
Adds the `hasBackdrop` input to the drawer container, allowing users to disable the backdrop.

Fixes angular#5300.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 13, 2018
Adds the `hasBackdrop` input to the drawer container, allowing users to disable the backdrop.

Fixes angular#5300.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 16, 2018
Adds the `hasBackdrop` input to the drawer container, allowing users to disable the backdrop.

Fixes angular#5300.
jelbourn pushed a commit that referenced this issue Jan 21, 2018
Adds the `hasBackdrop` input to the drawer container, allowing users to disable the backdrop.

Fixes #5300.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 30, 2018
Adds the `hasBackdrop` input to the drawer container, allowing users to disable the backdrop.

Fixes angular#5300.
jelbourn pushed a commit that referenced this issue Feb 13, 2018
Adds the `hasBackdrop` input to the drawer container, allowing users to disable the backdrop.

Fixes #5300.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants