Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determinate progress-bar broken in @angular rc1 #430 [Still not working] #519

Closed
Pixcell opened this issue May 25, 2016 · 5 comments
Closed
Assignees
Labels
P2 The issue is important to a large percentage of users, with a workaround
Milestone

Comments

@Pixcell
Copy link

Pixcell commented May 25, 2016

Bug, feature request, or proposal:

Bug (#430)

I did everything like you said before closing the issue 430, but it is still not working (cf my last response)
I think you don't see comment notifications on closed issues, so I open a new one.

What is the expected behavior?

Progress bar to be filled with correct percentage

What is the current behavior?

screen shot 2016-05-17 at 08 48 40

screen shot 2016-05-17 at 08 56 05

What are the steps to reproduce?

import {MdToolbar} from '@angular2-material/toolbar';
import {MdButton} from '@angular2-material/button';
import {MdCard} from '@angular2-material/card';
import {MdProgressBar} from '@angular2-material/progress-bar';

@Component({
  selector: 'home',
  templateUrl: 'components/home/home.component.html',
  styleUrls: ['components/home/home.component.css'],
  providers: [],
  directives: [MdToolbar, MdButton, MdCard, MdProgressBar]
})
export class HomeComponent implements OnInit{
<p>
     <span>PID completion {{h.pid.percentage}}%</span><span *ngIf="h.pid.warning">{{h.pid.warning}}        </span>
    <md-progress-bar mode="determinate" [value]="h.pid.percentage"></md-progress-bar>
</p>

Providing a Plunker (or similar) is the best way to get the team to see your issue.
Plunker template: http://plnkr.co/edit/o077B6uEiiIgkC0S06dd

What is the use-case or motivation for changing an existing behavior?

Which versions of Angular, Material, OS, browsers are affected?

    "@angular/common": "^2.0.0-rc.1",
    "@angular/compiler": "^2.0.0-rc.1",
    "@angular/core": "^2.0.0-rc.1",
    "@angular/http": "^2.0.0-rc.1",
    "@angular/platform-browser": "^2.0.0-rc.1",
    "@angular/platform-browser-dynamic": "^2.0.0-rc.1",
    "@angular/router": "^2.0.0-rc.1",
    "@angular/router-deprecated": "^2.0.0-rc.1",
    "@angular2-material/button": "^2.0.0-alpha.4",
    "@angular2-material/card": "^2.0.0-alpha.4",
    "@angular2-material/checkbox": "^2.0.0-alpha.4",
    "@angular2-material/core": "^2.0.0-alpha.4",
    "@angular2-material/icon": "^2.0.0-alpha.4",
    "@angular2-material/input": "^2.0.0-alpha.4",
    "@angular2-material/progress-bar": "^2.0.0-alpha.4",
    "@angular2-material/progress-circle": "^2.0.0-alpha.4",
    "@angular2-material/radio": "^2.0.0-alpha.4",
    "@angular2-material/sidenav": "^2.0.0-alpha.4",
    "@angular2-material/toolbar": "^2.0.0-alpha.4",

Is there anything else we should know?

Working with Chrome Version 50.0.2661.94 (64-bit) on Mac OSX

Please tell me if you need anything else.

@devversion
Copy link
Member

@Pixcell This works fine for me.

Can you modify the Plunker, to represent your issue?

@jelbourn
Copy link
Member

@josephperrott I can reproduce this in my material2 sample app; we can take a look next time you're around

@jelbourn jelbourn added the P2 The issue is important to a large percentage of users, with a workaround label May 25, 2016
@jelbourn jelbourn added this to the alpha.6 milestone May 25, 2016
@Pixcell
Copy link
Author

Pixcell commented May 26, 2016

@devversion, I tried a lot of things (even getting values from a webservice), but I can't reproduce the issue inside the plunker, sorry.
I'm somewhat glad that @jelbourn managed to reproduce it inside his demo app (Because otherwise I would feel very stupid)

I would really appreciate if you could keep me in the loop about this issue, and tell me what was the cause when you find it.

Just let me know if I can help in anyway.

@Pixcell
Copy link
Author

Pixcell commented Jun 2, 2016

Thanks a lot, it was fixed with release of alpha.5-2 !

andrewseguin pushed a commit to andrewseguin/components that referenced this issue Oct 15, 2018
* Currently if someone visits a link that contains a fragment that refers to an anchor element, the element won't be scrolled into view properly. This is because the `focusOnNavigation` calls `focus()` after the scroll into view. This causes the focused element to be visible in view.
* Removes an unnecessary workaround for fixing fragment URLs.

Fixes angular#396
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Development

No branches or pull requests

4 participants