Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling ripple globally does not work on tabs. #4235

Closed
itismelito opened this issue Apr 24, 2017 · 4 comments · Fixed by #4238
Closed

Disabling ripple globally does not work on tabs. #4235

itismelito opened this issue Apr 24, 2017 · 4 comments · Fixed by #4238
Assignees
@devversion
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@itismelito
Copy link

itismelito commented Apr 24, 2017 •
edited
Loading

I am disabling ripple globally since this is available in beta3 release but it seems it does not disable ripple effect on tabs. I am using MD_RIPPLE_GLOBAL_OPTIONS in the main app module as a provider like the example below:

providers: [{ provide: MD_RIPPLE_GLOBAL_OPTIONS, useValue: { disabled: true } }]

All other components that use ripple are disabled at this point except tabs. Is this a bug or am i missing something in my implementation?
@devversion devversion self-assigned this Apr 24, 2017
@devversion devversion added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent in progress labels Apr 24, 2017
devversion added a commit to devversion/material2 that referenced this issue Apr 24, 2017
@devversion
fix(ripple): global ripple configuration on init
9ea0c37 
* Currently when no bindings are set on the `mdRipple` target, the `ngOnChanges` will not fire and the `globalRippleOptions` will be ignored forever.

Fixes angular#4235
@devversion devversion mentioned this issue Apr 24, 2017
Merged
mmalerba pushed a commit that referenced this issue Apr 25, 2017
@devversion @mmalerba
fix(ripple): global ripple configuration on init (#4238)
9a2c4d6 
* Currently when no bindings are set on the `mdRipple` target, the `ngOnChanges` will not fire and the `globalRippleOptions` will be ignored forever.

Fixes #4235
@anapanadero
Copy link

I have the same problem

@devversion
Copy link
Member

@anapanadero The next release will include the fix for this issue.

@anapanadero
Copy link

Great! Thanks

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ripple): global ripple configuration on init devversion/material2
3 participants
@devversion @anapanadero @itismelito