Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(COMPONENT): Sort Header #30196

Closed
1 task done
smil-thakur opened this issue Dec 17, 2024 · 3 comments · Fixed by #30217
Closed
1 task done

bug(COMPONENT): Sort Header #30196

smil-thakur opened this issue Dec 17, 2024 · 3 comments · Fixed by #30217
Assignees
Labels
Accessibility This issue is related to accessibility (a11y) area: material/sort P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@smil-thakur
Copy link

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

v18

Description

When focusing on sort header using "tab" key previously on version 18 the sort headers were visible with less opacity but on version 19 the header icons are not visible

old;:
Image

new:
Image

as you can see on new one the header icons not visible on focus

Reproduction

https://material.angular.io/components/sort/overview

check over here and compare with

https://v18.material.angular.io/components/sort/overview

Expected Behavior

expected behavior should be sort icon should be visible with some opacity on focus and on click or enter press it should be visible with full opacity

Actual Behavior

sort icon is not at all visible on focus

Environment

  • Angular: 19
  • CDK/Material: 19
  • Browser(s): chrome
  • Operating System (e.g. Windows, macOS, Ubuntu): windows
@smil-thakur smil-thakur added the needs triage This issue needs to be triaged by the team label Dec 17, 2024
@amysorto amysorto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) area: material/sort and removed needs triage This issue needs to be triaged by the team labels Dec 17, 2024
@smil-thakur
Copy link
Author

@amysorto sorry for pinging, if want to look into this problem how can is test it locally, like i cloned the repo, installed packages through yarn install, but was not able to run something to test it locally, can you guide me or share some docs for runinng and testing material components locally and fixing problems

@amysorto
Copy link
Contributor

amysorto commented Dec 18, 2024

@smil-thakur If you are interested in looking into contributing a fix, here are instructions for our repo to set up your dev environment: https://github.com/angular/components/blob/main/DEV_ENVIRONMENT.md. The dev app has examples for table once it's run locally which you can test with.

@crisbeto crisbeto self-assigned this Dec 19, 2024
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 19, 2024
Fixes that the sort header wasn't showing the arrow when it's focused.

Fixes angular#30196.
crisbeto added a commit that referenced this issue Dec 19, 2024
Fixes that the sort header wasn't showing the arrow when it's focused.

Fixes #30196.

(cherry picked from commit 1c1ebfd)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) area: material/sort P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants