Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(mat-chip): Higlighted not working for m3 experimental themes #28923

Closed
1 task
dzivoing opened this issue Apr 21, 2024 · 1 comment · Fixed by #29001
Closed
1 task

bug(mat-chip): Higlighted not working for m3 experimental themes #28923

dzivoing opened this issue Apr 21, 2024 · 1 comment · Fixed by #29001
Assignees
@crisbeto
Labels
area: material/chips M3 P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@dzivoing
Copy link

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

There is a problem with highlighted directive on mat-chip not working properly

<mat-chip [highlighted]="true">Selected</mat-chip>

Reproduction

StackBlitz link:
Steps to reproduce:

  1. Create new mat chip with higlighted set to true

Repro stackblitz
https://stackblitz.com/edit/tmtuew-ycuj8s?file=src%2Ftheme.scss

Expected Behavior

Expected: background color should change to primary.

Actual Behavior

When you add highlighted to mat-chip it stay in the default state.

Environment

  • Angular: 17.3.5
  • CDK/Material: 17.3.5
  • Browser(s): Edge, Chrome
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows
@dzivoing dzivoing added the needs triage This issue needs to be triaged by the team label Apr 21, 2024
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent area: material/chips M3 and removed needs triage This issue needs to be triaged by the team labels May 3, 2024
crisbeto added a commit to crisbeto/material2 that referenced this issue May 4, 2024
@crisbeto
fix(material/chips): highlighted not working in M3
16e857e 
Remaps some of the tokens so that the `highlighted` input can work in M3.

Fixes angular#28923.
@crisbeto crisbeto self-assigned this May 4, 2024
@crisbeto crisbeto mentioned this issue May 4, 2024
Merged
crisbeto added a commit that referenced this issue May 5, 2024
@crisbeto
fix(material/chips): highlighted not working in M3 (#29001)
271490d 
Remaps some of the tokens so that the `highlighted` input can work in M3.

Fixes #28923.
crisbeto added a commit that referenced this issue May 5, 2024
@crisbeto
fix(material/chips): highlighted not working in M3 (#29001)
e024c12 
Remaps some of the tokens so that the `highlighted` input can work in M3.

Fixes #28923.

(cherry picked from commit 271490d)
crisbeto added a commit that referenced this issue May 5, 2024
@crisbeto
fix(material/chips): highlighted not working in M3 (#29001)
72baa7c 
Remaps some of the tokens so that the `highlighted` input can work in M3.

Fixes #28923.

(cherry picked from commit 271490d)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: material/chips M3 P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/chips): highlighted not working in M3 crisbeto/material2
2 participants
@crisbeto @dzivoing