Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new recommended Google Fonts URL and query params #17697

Closed
magneticflux- opened this issue Nov 13, 2019 · 1 comment · Fixed by #17698
Closed

Use new recommended Google Fonts URL and query params #17697

magneticflux- opened this issue Nov 13, 2019 · 1 comment · Fixed by #17698
Labels
docs This issue is related to documentation

Comments

@magneticflux-
Copy link
Contributor

Documentation Feedback

Google Fonts now recommend including display=swap in font requests to add font-display: swap to the returned CSS and improve user experience during page load. This format should be included in the documentation example.

Reference to the change: google/fonts#358 (comment)

This change eliminates a Chrome Lighthouse auditing warning:

image

Affected documentation page: https://material.angular.io/guide/typography
@magneticflux- magneticflux- added the docs This issue is related to documentation label Nov 13, 2019
@magneticflux- magneticflux- mentioned this issue Nov 13, 2019
Merged
jelbourn pushed a commit that referenced this issue Nov 18, 2019
@magneticflux- @jelbourn
docs(guides/typography): update recommended font url (#17698)
36ab4d2 
Update the Google Fonts URL to include `display=swap` which is now recommended. This improves font loading performance and fixes a Google Lighthouse Audit warning.

Fixes #17697
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
docs This issue is related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(guides/typography): update recommended font url
2 participants
@devversion @magneticflux-