Update firebase.app.module.ts

[MingyuJeon]

Checklist

• Issue number for this PR: automaticDataCollectionEnabled' is missing in type 'FirebaseApp' #1571 (required)
• Docs included?: no
• Test units included?: no
• In a clean directory, yarn install, yarn test run successfully? yes

Description

Bug fix

Class FirebaseApp incorrectly implements interface 'FirebaseApp'.
Property `automaticDataCollectionEnabled` is missing in type FirebaseApp 

Code sample

firebase.app.module.d.ts

import {InjectionToken} from '@angular/core';
import {FirebaseAppConfig} from './';
import {FirebaseApp as FBApp} from '@firebase/app-types';
import {FirebaseAuth} from '@firebase/auth-types';
import {FirebaseDatabase} from '@firebase/database-types';
import {FirebaseMessaging} from '@firebase/messaging-types';
import {FirebaseStorage} from '@firebase/storage-types';
import {FirebaseFirestore} from '@firebase/firestore-types';

export declare const FirebaseAppConfigToken: InjectionToken<FirebaseAppConfig>;

export declare class FirebaseApp implements FBApp {
  name: string;
  automaticDataCollectionEnabled: boolean; // add here
  options: {};
  auth: () => FirebaseAuth;
  database: () => FirebaseDatabase;
  messaging: () => FirebaseMessaging;
  storage: () => FirebaseStorage;
  delete: () => Promise<any>;
  firestore: () => FirebaseFirestore;
}

export declare function _firebaseAppFactory(config: FirebaseAppConfig, appName?: string): FirebaseApp;

[sarunint]

Should we allow assigning the automaticDataCollectionEnabled parameter from the initializeApp method? This may lead to breaking change.

[Adonaye]

I have tried this solution and works well.
I changed it myself but users of Ionic Pro can not deal with it. It would be great to try it.

[MingyuJeon]

Even though you change firebase.app.module.ts to this, the error could happen because ionic pro npm install automatically when it build an app. So, if the error occurs, you would need to downgrade to @firebase/app@0.1.10 in this situation.

[jamesdaniels]

Thanks for the quick fix.

[jamesdaniels]

@sarunint I'll support the new Firebase initialize method style, which takes automaticDataCollectionEnabled as an argument in a follow on PR. Will want to bump the req in the package.json for that one.

[luq-sparrow]

The problem still occurs in Angular CLI.
I'm not using firebase/app.
Only angularfire2 and firebase to manage firestore calls.

Same error.

[sarunint]

That's because the fix in this PR has not been released yet.

[software770-2]

Is it realesed today ? How Do I fix it now ?